Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: #142 raw literal with backslashes becomes "unescaped"#143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
dim0xff wants to merge3 commits intosegmentio:master
base:master
Choose a base branch
Loading
fromdim0xff:bug/raw-literal-backslash

Conversation

@dim0xff
Copy link

@dim0xffdim0xff commentedAug 11, 2024•
edited
Loading

fix#142

macintacos, satvik007, and TN1ck reacted with thumbs up emoji
Copy link

@ccoVeilleccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I see no tests updated, wasn't any?

@dim0xff
Copy link
Author

dim0xff commentedAug 11, 2024•
edited
Loading

I see no tests updated, wasn't any?

@ccoVeille I added test to_fixtures/struct_tags.go and test expectation to_fixtures/struct_tags__exp.go

Fixtures are being tested viashortener_test.go

@ccoVeille
Copy link

Oh that's right. I expected the tests to be in a _test.go file

@mgabeler-lee-6rs
Copy link

I believe this will also fix#161 which is a dupe of#142

ccoVeille, gabyx, amanbolatdh, and satvik007 reacted with thumbs up emoji

@amanbolat
Copy link

Hi there,
Is there anything missing in this PR that requires contribution, or it can be merged?

@landonalder
Copy link

This is also a problem for us that I just discovered today. If this could be merged, that would be amazing@mckern

@ldezldez mentioned this pull requestOct 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@ccoVeilleccoVeilleccoVeille approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: raw literal with backslashes becomes "unescaped"

5 participants

@dim0xff@ccoVeille@mgabeler-lee-6rs@amanbolat@landonalder
[8]ページ先頭
©2009-2025 Movatter.jp