Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

visit_create_table method added to dialect#3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
PeterDKay merged 1 commit intomainfromtask/if-not-exists-to-create-table
Jul 19, 2023

Conversation

@PeterDKay
Copy link
Collaborator

Added create_table method to dialect to include 'IF NOT EXISTS' as default, preventing failed alembic upgrades.

@PeterDKayPeterDKay merged commitd34a7f9 intomainJul 19, 2023
PeterDKay pushed a commit that referenced this pull requestOct 3, 2024
* move py.typed to correct placeshttps://peps.python.org/pep-0561/ says 'For namespace packages (see PEP 420), the py.typed file should be in the submodules of the namespace, to avoid conflicts and for clarity.'. Previously, when I added the py.typed file to this project,databricks#382 , I was unaware this was a namespace package (although, curiously, it seems I had done it right initially and then changed to the wrong way). As PEP 561 warns us, this does create conflicts; other libraries in the databricks namespace package (such as, in my case, databricks-vectorsearch) are then treated as though they are typed, which they are not. This commit moves the py.typed file to the correct places, the submodule folders, fixing that problem.Signed-off-by: wyattscarpenter <wyattscarpenter@gmail.com>* change target of mypy to src/databricks instead of src.I think this might fix the CI code-quality checks failure, but unfortunately I can't replicate that failure locally and the error message is unhelpfulSigned-off-by: wyattscarpenter <wyattscarpenter@gmail.com>* Possible workaround for bad error message 'error: --install-types failed (no mypy cache directory)'; seepython/mypy#10768 (comment)Signed-off-by: wyattscarpenter <wyattscarpenter@gmail.com>* fix invalid yaml syntaxSigned-off-by: wyattscarpenter <wyattscarpenter@gmail.com>* Best fix (#3)Fixes the problem by cding and supplying a flag to mypy (that mypy needs this flag is seemingly fixed/changed in later versions of mypy; but that's another pr altogether...). Also fixes a type error that was somehow in the arguments of the program (?!) (I guess this is because you guys are still using implicit optional)---------Signed-off-by: wyattscarpenter <wyattscarpenter@gmail.com>* return the old result_links default (#5)Return the old result_links default, make the type optional, & I'm pretty sure the original problem is that add_file_links can't take a None, so these statements should be in the body of the if-statement that ensures it is not NoneSigned-off-by: wyattscarpenter <wyattscarpenter@gmail.com>* Update src/databricks/sql/utils.py"self.download_manager is unconditionally used later, so must be created. Looks this part of code is totally not covered with tests 🤔"Co-authored-by: Levko Kravets <levko.ne@gmail.com>Signed-off-by: wyattscarpenter <wyattscarpenter@gmail.com>---------Signed-off-by: wyattscarpenter <wyattscarpenter@gmail.com>Co-authored-by: Levko Kravets <levko.ne@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PeterDKay

[8]ページ先頭

©2009-2025 Movatter.jp