Commita799ee7

authored

Merge pull request#8 from sede-open/task/exclude-views-from-get-table-names

Removed commented out old method

2 parents84318f4 +b348193 commita799ee7Copy full SHA for a799ee7

File tree

-17

lines changed

-17

lines changed

Lines changed: 1 addition & 17 deletions

Original file line number	Diff line number	Diff line change
`@@ -259,28 +259,12 @@ def get_table_names(self, connection, schema=None, **kwargs):`
`259`	`259`	`AND table_type = 'MANAGED';""".format(`
`260`	`260`	`schema_str`
`261`	`261`	`)`
	`262`	`+# TODO: Add if scenario for None schema`
`262`	`263`	`data=cur.execute(sql_str).fetchall()`
`263`	`264`	`_tables= [i[TABLE_NAME]foriindata]`
`264`	`265`
`265`	`266`	`return_tables`
`266`	`267`
`267`		`-# TODO: Commented out this until can be deleted after successful tests`
`268`		`-# def get_table_names(self, connection, schema=None, **kwargs):`
`269`		`-# TABLE_NAME = 1`
`270`		-# catalog = "`" + self.catalog + "`"
`271`		-# schema = ("`" + schema + "`") or ("`" + self.schema + "`")
`272`		`-#`
`273`		`-# with self.get_driver_connection(`
`274`		`-# connection`
`275`		`-# )._dbapi_connection.dbapi_connection.cursor() as cur:`
`276`		`-# sql_str = "SHOW TABLES FROM {}".format(`
`277`		`-# ".".join([catalog, schema])`
`278`		`-# )`
`279`		`-# data = cur.execute(sql_str).fetchall()`
`280`		`-# _tables = [i[TABLE_NAME] for i in data]`
`281`		`-#`
`282`		`-# return _tables`
`283`		`-`
`284`	`268`	`defget_view_names(self,connection,schema=None,**kwargs):`
`285`	`269`	`VIEW_NAME=1`
`286`	`270`	`withself.get_driver_connection(`

Comments

(0)