Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Reduce Code Duplication#92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

Weltraumschaf
Copy link
Member

@WeltraumschafWeltraumschaf commentedSep 1, 2023•
edited
Loading

First steps to reduce the code duplication of the HTTP and Proxy code inImportScanService andGenericDefectDojoService.

Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@WeltraumschafWeltraumschaf marked this pull request as draftSeptember 1, 2023 15:27
@WeltraumschafWeltraumschaf self-assigned thisSep 1, 2023
@WeltraumschafWeltraumschaf added the enhancementNew feature or request labelSep 1, 2023
…o we can mock this out in the tests"This reverts commit99b039f.Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
will be used later to remove code duplication in the services.Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
…rtiesSigned-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
… code refactoringSigned-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
…bilitySigned-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
…e forbetter readabilitySigned-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@WeltraumschafWeltraumschaf changed the titleTry to resolve the Object generic parameter in MultiPArtRequestBodyReduce Code DuplicationSep 3, 2023
@WeltraumschafWeltraumschaf marked this pull request as ready for reviewSeptember 3, 2023 13:32
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
…o that's hard to see the code duplicationSigned-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Zero3141Zero3141 marked this pull request as draftSeptember 4, 2023 06:40
Zero3141
Zero3141 previously approved these changesSep 4, 2023
Copy link
Contributor

@Zero3141Zero3141 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some files miss the license header

@Zero3141Zero3141 marked this pull request as ready for reviewSeptember 4, 2023 12:38
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@WeltraumschafWeltraumschaf merged commit2e35251 intosecureCodeBox:mainSep 4, 2023
@WeltraumschafWeltraumschaf deleted the 36_refactoring branchSeptember 4, 2023 13:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Zero3141Zero3141Zero3141 approved these changes

Assignees

@WeltraumschafWeltraumschaf

Labels
enhancementNew feature or request
Projects
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Weltraumschaf@Zero3141
[8]ページ先頭
©2009-2025 Movatter.jp