- Notifications
You must be signed in to change notification settings - Fork12
#35 Test create and publish a release with automatic semantic versioning#73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
.github/workflows/release.yml Outdated
| - name: Get current version | ||
| id: version | ||
| run: echo "::set-output name=version::$(./gradlew -q -Prelease.quiet currentVersion)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What does this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Added a comment before this step to explain its purpose & functionality. Is this sufficient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That's a good starting point for the reason, but there should also be some info about the concrete syntax (::set-output name=version::). If you have a link which describes this, a link with a hint that it describes the syntax is sufficient.
Uh oh!
There was an error while loading.Please reload this page.
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Partlyfixes#35