Re-add test action#67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Weltraumschaf merged 2 commits intosecureCodeBox:mainfromZero3141:feature/add-test-ci-for-pr-checks

Jul 28, 2023

Merged

Re-add test action#67

Weltraumschaf merged 2 commits intosecureCodeBox:mainfromZero3141:feature/add-test-ci-for-pr-checks

Jul 28, 2023

Conversation

Copy link

Contributor

Zero3141 commentedJul 28, 2023

With this we prevent merging of branches with failing tests into main

Zero3141and others added2 commits

July 27, 2023 14:58

Create SECURITY.md

437689d

Signed-off-by: Heiko Kiesel <45092958+Zero3141@users.noreply.github.com>

Add gradle test workflow

57d6b5e

Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>

Zero3141 added the enhancementNew feature or request label

Jul 28, 2023

Zero3141 requested a review fromWeltraumschaf

July 28, 2023 10:00

Zero3141 self-assigned this

Jul 28, 2023

Copy link

Member

Weltraumschaf commentedJul 28, 2023

Why is this not covered by ci.yaml?

Copy link

ContributorAuthor

Zero3141 commentedJul 28, 2023

Why is this not covered by ci.yaml?

The ci.yaml only works when pushing to the main branch as its main purpose is to publish it as a snapshot to maven central. If we want to restrict merges to only check-passing ones, we need to run the checks also for the PRs. This is now implemented in the test.yml, which runs on all branches