Port: Improve Error Message on Failed Attachment of Finding#120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Weltraumschaf merged 1 commit intosecureCodeBox:mainfromWeltraumschaf:fix_error_handling_in_main

Feb 14, 2024

Merged

Port: Improve Error Message on Failed Attachment of Finding#120

Weltraumschaf merged 1 commit intosecureCodeBox:mainfromWeltraumschaf:fix_error_handling_in_main

Feb 14, 2024

Conversation

Copy link

Member

Weltraumschaf commentedFeb 14, 2024•
edited
Loading

This PR ports thisenhancement into main branch.

Relates tosecureCodeBox/secureCodeBox#2271

Improve Error Message on Failed attachment of Finding

88d2a93

The original code does not provide the causing error, which makesit dificult to debug the problem.- Add first adding loggign capabilities via SLF4J.- Log the failed attempt of attaching a finding as eror w/ original  exception message.- Pass the causing exception to the exception we rethrow to preserve  the full stack trace.Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>

Weltraumschaf self-assigned this

Feb 14, 2024

Weltraumschaf added the enhancementNew feature or request label

Feb 14, 2024

Weltraumschaf requested a review fromJ12934

February 14, 2024 15:34

Weltraumschaf changed the title~~Backport: Improve Error Message on Failed attachment of Finding~~Port: Improve Error Message on Failed attachment of Finding

Feb 14, 2024

Weltraumschaf changed the title~~Port: Improve Error Message on Failed attachment of Finding~~Port: Improve Error Message on Failed Attachment of Finding

Feb 14, 2024