Commitbf98384

authored

Better comments (#84)

* better comments* status

1 parent53506d1 commitbf98384Copy full SHA for bf98384

File tree

+14

-4

lines changed

+14

-4

lines changed

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -22,8 +22,6 @@`
`22`	`22`	`importnumpy`
`23`	`23`	`importpandas`
`24`	`24`	`fromlightgbmimportLGBMRegressor`
`25`		`-fromonnxmltools.convert.lightgbm.operator_converters.LightGbmimportconvert_lightgbm`
`26`		`-fromonnxmltools.convert.xgboost.operator_converters.XGBoostimportconvert_xgboost`
`27`	`25`	`fromonnxruntimeimportInferenceSession,SessionOptions`
`28`	`26`	`frompsutilimportcpu_count`
`29`	`27`	`fromsphinx_runpython.runpythonimportrun_cmd`
`@@ -33,9 +31,14 @@`
`33`	`31`	`fromsklearn.ensembleimportRandomForestRegressor`
`34`	`32`	`fromtqdmimporttqdm`
`35`	`33`	`fromxgboostimportXGBRegressor`
	`34`	`+fromonnxmltools.convert.xgboost.operator_converters.XGBoostimportconvert_xgboost`
`36`	`35`
`37`	`36`
`38`	`37`	`defskl2onnx_convert_lightgbm(scope,operator,container):`
	`38`	`+fromonnxmltools.convert.lightgbm.operator_converters.LightGbmimport (`
	`39`	`+convert_lightgbm,`
	`40`	`+ )`
	`41`	`+`
`39`	`42`	`options=scope.get_options(operator.raw_operator)`
`40`	`43`	`if"split"inoptions:`
`41`	`44`	`operator.split=options["split"]`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -123,8 +123,14 @@ def _cmd_compare(argv: List[Any]):`
`123`	`123`
`124`	`124`	`parser=get_parser_compare()`
`125`	`125`	`args=parser.parse_args(argv[1:])`
	`126`	`+ifargs.verbosein ("1",1,"True",True):`
	`127`	`+print(f"[compare] first model{args.model1!r}")`
	`128`	`+print(f"[compare] second model{args.model2!r}")`
`126`	`129`	`onx1=onnx.load(args.model1)`
`127`	`130`	`onx2=onnx.load(args.model2)`
	`131`	`+ifargs.verbosein ("1",1,"True",True):`
	`132`	`+print(f"[compare] first model has{len(onx1.graph.node)} nodes")`
	`133`	`+print(f"[compare] second model has{len(onx2.graph.node)} nodes")`
`128`	`134`	`res1,res2,align,dc=compare_onnx_execution(`
`129`	`135`	`onx1,`
`130`	`136`	`onx2,`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -642,15 +642,16 @@ def compare_onnx_execution(`
`642`	`642`	`print("[compare_onnx_execution] loading first model")`
`643`	`643`	`proto1=load(model1)ifisinstance(model1,str)elsemodel1`
`644`	`644`	`ifverbose:`
`645`		`-print("[compare_onnx_execution] loadingfirst model")`
	`645`	`+print("[compare_onnx_execution] loadingsecond model")`
`646`	`646`	`proto2=load(model2)ifisinstance(model2,str)elsemodel2`
`647`	`647`	`res1=list(_enumerate_result_no_execution(proto1))`
`648`	`648`	`res2=list(_enumerate_result_no_execution(proto2))`
`649`	`649`	`else:`
`650`	`650`	`return`
`651`	`651`
`652`	`652`	`ifverbose:`
`653`		`-print(f"[compare_onnx_execution] got{len(res2)} results")`
	`653`	`+print(f"[compare_onnx_execution] got{len(res1)} results (first model)")`
	`654`	`+print(f"[compare_onnx_execution] got{len(res2)} results (second model)")`
`654`	`655`	`print("[compare_onnx_execution] compute edit distance")`
`655`	`656`	`dc=DistanceExecution()`
`656`	`657`	`_,align=dc.distance_sequence(res1,res2)`

Comments

(0)