Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.7k
parameterize MS_LOGIN_URL#988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
srvrguy commentedAug 2, 2022
Is this a good candidate to get added to this code? I'd like to use this library, but basically have to make my own custom solution to supporting national cloud login. If there is something that needs to be changed, some feedback would be good so someone else can try submitting a PR or the original contributor could provide a fix to get this integrated. |
gellweiler commentedApr 12, 2024
I also have a customer that wants to connect to a "national" cloud. It's off course relative easy to extend the class and override the url but I think it would be a good addition to the Scribejava core. So I second this. |
Because Azure Active Directory supports four kind of LOGIN_URL (see:Azure AD authentication endpoints):
So, we need to make MS_LOGIN_URL a constructor parameter.