Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

parameterize MS_LOGIN_URL#988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
kimim wants to merge2 commits intoscribejava:master
base:master
Choose a base branch
Loading
fromkimim:master
Open

parameterize MS_LOGIN_URL#988

kimim wants to merge2 commits intoscribejava:masterfromkimim:master

Conversation

kimim
Copy link

Because Azure Active Directory supports four kind of LOGIN_URL (see:Azure AD authentication endpoints):

So, we need to make MS_LOGIN_URL a constructor parameter.

@srvrguy
Copy link

Is this a good candidate to get added to this code? I'd like to use this library, but basically have to make my own custom solution to supporting national cloud login. If there is something that needs to be changed, some feedback would be good so someone else can try submitting a PR or the original contributor could provide a fix to get this integrated.

@gellweiler
Copy link

I also have a customer that wants to connect to a "national" cloud. It's off course relative easy to extend the class and override the url but I think it would be a good addition to the Scribejava core. So I second this.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@kimim@srvrguy@gellweiler@jijun99

[8]ページ先頭

©2009-2025 Movatter.jp