Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitcbad67e

Browse files
committed
add chaining methods for HTTP clients configs
1 parent923d7e4 commitcbad67e

File tree

4 files changed

+55
-4
lines changed

4 files changed

+55
-4
lines changed

‎scribejava-core/src/main/java/com/github/scribejava/core/httpclient/jdk/JDKHttpClientConfig.java

Lines changed: 32 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,11 @@ public void setConnectTimeout(Integer connectTimeout) {
2828
this.connectTimeout =connectTimeout;
2929
}
3030

31+
publicJDKHttpClientConfigwithConnectTimeout(IntegerconnectTimeout) {
32+
this.connectTimeout =connectTimeout;
33+
returnthis;
34+
}
35+
3136
publicIntegergetReadTimeout() {
3237
returnreadTimeout;
3338
}
@@ -36,8 +41,9 @@ public void setReadTimeout(Integer readTimeout) {
3641
this.readTimeout =readTimeout;
3742
}
3843

39-
publicbooleanisFollowRedirects() {
40-
returnfollowRedirects;
44+
publicJDKHttpClientConfigwithReadTimeout(IntegerreadTimeout) {
45+
this.readTimeout =readTimeout;
46+
returnthis;
4147
}
4248

4349
publicvoidsetProxy(Proxyproxy) {
@@ -48,6 +54,15 @@ public Proxy getProxy() {
4854
returnproxy;
4955
}
5056

57+
publicJDKHttpClientConfigwithProxy(Proxyproxy) {
58+
this.proxy =proxy;
59+
returnthis;
60+
}
61+
62+
publicbooleanisFollowRedirects() {
63+
returnfollowRedirects;
64+
}
65+
5166
/**
5267
* Sets whether the underlying Http Connection follows redirects or not.
5368
*
@@ -60,4 +75,19 @@ public Proxy getProxy() {
6075
publicvoidsetFollowRedirects(booleanfollowRedirects) {
6176
this.followRedirects =followRedirects;
6277
}
78+
79+
/**
80+
* Sets whether the underlying Http Connection follows redirects or not.
81+
*
82+
* Defaults to true (follow redirects)
83+
*
84+
* @see <a
85+
* href="http://docs.oracle.com/javase/6/docs/api/java/net/HttpURLConnection.html#setInstanceFollowRedirects(boolean)">http://docs.oracle.com/javase/6/docs/api/java/net/HttpURLConnection.html#setInstanceFollowRedirects(boolean)</a>
86+
* @param followRedirects boolean
87+
* @return this for chaining methods invocations
88+
*/
89+
publicJDKHttpClientConfigwithFollowRedirects(booleanfollowRedirects) {
90+
this.followRedirects =followRedirects;
91+
returnthis;
92+
}
6393
}

‎scribejava-httpclient-armeria/src/main/java/com/github/scribejava/httpclient/armeria/ArmeriaHttpClientConfig.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ public ArmeriaHttpClientConfig(ClientOptions clientOptions, ClientFactory client
3333

3434
/**
3535
* Creates new {@link HttpClientConfig} using default settings.
36+
*
37+
* @return new {@link HttpClientConfig} using default settings.
3638
*/
3739
@Override
3840
publicHttpClientConfigcreateDefaultConfig() {
@@ -62,14 +64,29 @@ public void setProtocolPreference(SessionProtocol protocolPreference) {
6264
this.protocolPreference =protocolPreference;
6365
}
6466

67+
publicArmeriaHttpClientConfigwithProtocolPreference(SessionProtocolprotocolPreference) {
68+
setProtocolPreference(protocolPreference);
69+
returnthis;
70+
}
71+
6572
publicvoidsetRetry(Function<?superHttpClient,RetryingClient>retry) {
6673
this.retry =retry;
6774
}
6875

76+
publicArmeriaHttpClientConfigwithRetry(Function<?superHttpClient,RetryingClient>retry) {
77+
this.retry =retry;
78+
returnthis;
79+
}
80+
6981
publicvoidsetLogging(Function<?superHttpClient,LoggingClient>logging) {
7082
this.logging =logging;
7183
}
7284

85+
publicArmeriaHttpClientConfigwithLogging(Function<?superHttpClient,LoggingClient>logging) {
86+
this.logging =logging;
87+
returnthis;
88+
}
89+
7390
ArmeriaWebClientBuildercreateClientBuilder() {
7491
returnnewArmeriaWebClientBuilder(clientOptions,clientFactory,protocolPreference,retry,logging);
7592
}

‎scribejava-httpclient-armeria/src/test/java/com/github/scribejava/httpclient/armeria/ArmeriaHttpClientTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,8 @@ protected HttpClient createNewClient() {
4747
.onStatus(HttpStatus.SERVICE_UNAVAILABLE)
4848
.onUnprocessed()
4949
.thenBackoff(retryBackoff);
50-
config.setRetry(RetryingClient.newDecorator(retryRule));
5150

52-
returnnewArmeriaHttpClient(config);
51+
returnnewArmeriaHttpClient(config.withRetry(RetryingClient.newDecorator(retryRule)));
5352
}
5453

5554
// No-Op DNS resolver to avoid resolution issues in the unit test

‎scribejava-httpclient-ning/src/main/java/com/github/scribejava/httpclient/ning/NingHttpClientConfig.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,11 @@ public void setNingAsyncHttpProviderClassName(String ningAsyncHttpProviderClassN
2020
this.ningAsyncHttpProviderClassName =ningAsyncHttpProviderClassName;
2121
}
2222

23+
publicNingHttpClientConfigwithNingAsyncHttpProviderClassName(StringningAsyncHttpProviderClassName) {
24+
this.ningAsyncHttpProviderClassName =ningAsyncHttpProviderClassName;
25+
returnthis;
26+
}
27+
2328
publicAsyncHttpClientConfiggetConfig() {
2429
returnconfig;
2530
}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp