NotificationsYou must be signed in to change notification settings
Fork11.2k
Star59.1k

Deprecate send_catch_log_deferred().#7161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

wRAR wants to merge6 commits intoscrapy:master

base:master

Choose a base branch

fromwRAR:send_catch_log_async

Draft

Deprecate send_catch_log_deferred().#7161

wRAR wants to merge6 commits intoscrapy:masterfromwRAR:send_catch_log_async

+188 −74

Conversation

Copy link

Member

wRAR commentedNov 23, 2025

No description provided.

wRAR added this to theScrapy 2.14 milestone

Nov 23, 2025

wRAR added enhancement asyncio labels

Nov 23, 2025

Copy link

codecovbot commentedNov 23, 2025•
edited
Loading

❌ Patch coverage is95.65217% with3 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.39%. Comparing base (1e8de24) to head (b1dac63).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
scrapy/core/engine.py	91.66%	0 Missing and 1 partial⚠️
scrapy/extensions/feedexport.py	95.83%	0 Missing and 1 partial⚠️
scrapy/utils/signal.py	96.77%	1 Missing⚠️

Additional details and impacted files

@@            Coverage Diff             @@##           master    #7161      +/-   ##==========================================- Coverage   91.40%   91.39%   -0.01%==========================================  Files         165      165                Lines       12636    12669      +33       Branches     1619     1623       +4     ==========================================+ Hits        11550    11579      +29- Misses        813      817       +4  Partials      273      273

Files with missing lines	Coverage Δ
scrapy/signalmanager.py	`93.93% <100.00%> (-0.18%)`	⬇️
scrapy/core/engine.py	`88.85% <91.66%> (+0.53%)`	⬆️
scrapy/extensions/feedexport.py	`96.01% <95.83%> (-1.22%)`	⬇️
scrapy/utils/signal.py	`97.43% <96.77%> (-0.65%)`	⬇️