Codecov Report

❌ Patch coverage is95.31250% with3 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.44%. Comparing base (b49aa2f) to head (42f40fa).
⚠️ Report is 11 commits behind head on master.
✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@##           master    #7090      +/-   ##==========================================+ Coverage   91.10%   91.44%   +0.34%==========================================  Files         165      165                Lines       12836    12694     -142       Branches     1661     1626      -35     ==========================================- Hits        11694    11608      -86+ Misses        859      811      -48+ Partials      283      275       -8

The test passes without the download handler changes so we need a better one, but I'm not sure whether is it possible. It looks like v6 proxies are indeed (as the issue discussion says) supported in master when used with an IP so we need to use a hostname?

The test passes without the download handler changes so we need a better one, but I'm not sure whether is it possible. It looks like v6 proxies are indeed (as the issue discussion says) supported in master when used with an IP so we need to use a hostname?

We can show that the correctClientEndpoint selected with a test that monkeypatchessocket.getaddrinfo to return an IPv6 result and assertsScrapyProxyAgent._getEndpoint chooses aTCP6ClientEndpoint.
Still thinking about a better test :]

def_make_agent(proxy_uri:bytes):agent=ScrapyProxyAgent(reactor=reactor,proxyURI=proxy_uri)# a minimal endpointFactory expected by _getEndpointagent._endpointFactory=type("EF", (), {"_connectTimeout":5.0,"_bindAddress":None})()returnagentdeftest_hostname_resolves_to_ipv6(monkeypatch):# Simulate DNS resolving the hostname to an IPv6 addressdeffake_getaddrinfo(host,port,*args,**kwargs):return [            (socket.AF_INET6,socket.SOCK_STREAM,socket.IPPROTO_TCP,"", ("::1",0,0,0))        ]monkeypatch.setattr(socket,"getaddrinfo",fake_getaddrinfo)agent=_make_agent(b"http://ipv6-resolves.example:8080")endpoint=agent._getEndpoint(agent._proxyURI)assertisinstance(endpoint,TCP6ClientEndpoint)