- Notifications
You must be signed in to change notification settings - Fork11.2k
AddDownloaderMiddlewareManager.download_async(), deprecate returning Deferreds from downloader mws#7069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
wRAR wants to merge10 commits intoscrapy:masterChoose a base branch fromwRAR:downloader-mw-async
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
AddDownloaderMiddlewareManager.download_async(), deprecate returning Deferreds from downloader mws#7069
Changes from1 commit
Commits
Show all changes
10 commits Select commitHold shift + click to select a range
6f3e7f4 Restore coverage in MiddlewareManager spider arg handling.
wRAR3de1de7 Move MiddlewareManager._warn_spider_arg() tests.
wRARec0c813 Add DownloaderMiddlewareManager.download_async().
wRAR1fafd8c Make download_func async.
wRARca65eb7 Inline MiddlewareManager._warn_spider_arg().
wRAR83544e8 Merge branch 'master' into downloader-mw-async
wRARf170457 Deprecate returning deferreds from downloader middlewares.
wRAR02ebee4 Update the downloader mw doc about async def.
wRAR3afbbd3 Merge branch 'master' into downloader-mw-async
wRARbcc76d7 Use global_object_name() instead of repr().
wRARFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Inline MiddlewareManager._warn_spider_arg().
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitca65eb76cca5ef465fe2aa89f1cbaf9af7feba43
There are no files selected for viewing
12 changes: 11 additions & 1 deletionscrapy/core/spidermw.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
13 changes: 0 additions & 13 deletionsscrapy/middleware.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.