- Notifications
You must be signed in to change notification settings - Fork48
Refactor KMedoids#140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
adrinjalali left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
So, the tests in the private methods are failing. What should we do?
That's quite normal. We should be testing everything in the library, and sometimes it's easier to test smaller parts of the code which sometimes happen to be private.
| -id:trailing-whitespace | ||
| -repo:https://github.com/psf/black | ||
| rev:20.8b1 | ||
| rev:22.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thanks for this change, but it should be a separate PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
True.
I tried to reduce the cyclomatic complexity in k medoids.
During refactoring I realized that we are testing private methods. Why is that?
So, the tests in the private methods are failing. What should we do?
Make the methods public, document and test them or just remove the tests by replace them with behavior testing on public methods?
I think that tests could be improved in general.