Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FIX make sure to accept "minority" as a valid strategy in over-samplers#964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
glemaitre merged 3 commits intoscikit-learn-contrib:masterfromPrakhyath07:master
Dec 28, 2022

Conversation

Prakhyath07
Copy link
Contributor

Reference Issue

What does this implement/fix? Explain your changes.

while using smapling strategy ="minority" we were getting error. i found issue in base.py of oversampler where in _parameter constraint majority was used in stroptions instead of minority

Any other comments?

updated majority to minority  in str options:  _parameter_constraints: dict = {        "sampling_strategy": [            Interval(numbers.Real, 0, 1, closed="right"),            StrOptions({"auto", "minority", "not minority", "not majority", "all"}),            Mapping,            callable,        ],        "random_state": ["random_state"],    }
@codecov
Copy link

codecovbot commentedDec 23, 2022•
edited
Loading

Codecov Report

Base:96.50% // Head:94.25% // Decreases project coverage by-2.24%⚠️

Coverage data is based on head(14c4a8b) compared to base(7cead9c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@##           master     #964      +/-   ##==========================================- Coverage   96.50%   94.25%   -2.25%==========================================  Files         103      103                Lines        7264     7280      +16       Branches     1068     1071       +3     ==========================================- Hits         7010     6862     -148- Misses        147      312     +165+ Partials      107      106       -1
Impacted FilesCoverage Δ
imblearn/over_sampling/base.py100.00% <ø> (ø)
...rn/over_sampling/tests/test_random_over_sampler.py100.00% <100.00%> (ø)
...otype_selection/tests/test_random_under_sampler.py100.00% <100.00%> (ø)
...ing/_prototype_selection/tests/test_tomek_links.py100.00% <100.00%> (ø)
imblearn/keras/tests/test_generator.py9.37% <0.00%> (-90.63%)⬇️
imblearn/tensorflow/_generator.py27.58% <0.00%> (-68.97%)⬇️
imblearn/tensorflow/tests/test_generator.py10.75% <0.00%> (-54.84%)⬇️
imblearn/keras/_generator.py45.20% <0.00%> (-46.58%)⬇️
imblearn/tests/test_docstring_parameters.py87.32% <0.00%> (-0.71%)⬇️

Help us with your feedback. Take ten seconds to tell ushow you rate us. Have a feature suggestion?Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment?Let us know in this issue.

@glemaitreglemaitre changed the titleupdated sampling strategy string of oversampler base.py from majority to minorityFIX make sure to accept "minority" as a valid strategy in over-samplersDec 28, 2022
@glemaitre
Copy link
Member

I added some non-regression tests and an entry in the changelog.
I will probably try to make a release soon because it is a blocker.

@glemaitreglemaitre merged commit79107e8 intoscikit-learn-contrib:masterDec 28, 2022
@glemaitre
Copy link
Member

Thanks@Prakhyath07 I will fix the CI builds that are failing. There are not related.

glemaitre added a commit that referenced this pull requestDec 28, 2022
…rs (#964)Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@Prakhyath07
Copy link
ContributorAuthor

Reference Issue

What does this implement/fix? Explain your changes.

while using smapling strategy ="minority" we were getting error. i found issue in base.py of oversampler where in _parameter constraint majority was used in stroptions instead of minority

Any other comments?

From my side i didn't find any other issue
Thank you so much

@dront78
Copy link

where is 0.10.1?

@glemaitre
Copy link
Member

On PyPI and conda-forge, e.g.https://pypi.org/project/imbalanced-learn/

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Prakhyath07@glemaitre@dront78
[8]ページ先頭
©2009-2025 Movatter.jp