- Notifications
You must be signed in to change notification settings - Fork1.3k
MAINT make imbalanced-learn compatible with scikit-learn 1.+#946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
glemaitre merged 12 commits intoscikit-learn-contrib:masterfromglemaitre:sync_sklearn_1.2Dec 2, 2022
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
Show all changes
12 commits Select commitHold shift + click to select a range
d069215
MAINT fix BalancedBaggingClassifier
glemaitre47c48cb
MAINT fix linting CI
glemaitre2b1dd69
MAINT flake8
glemaitre3d21ade
MAINT remove Win32
glemaitre110297b
MAINT improve doc and add test to BalancedBaggingClassifier
glemaitre8a8bbe3
MAINT fix EasyEnsemble
glemaitre7e736f2
MAINT fix RUSBoostClassifier
glemaitre318ee01
MAINT fix BalancedRandomForest
glemaitre28663da
DOC
glemaitre17dcdd5
MAINT trigger RC install
glemaitrec4e8b75
MAINT upgrade CIs
glemaitre7beb41a
iter
glemaitreFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
2 changes: 1 addition & 1 deletionREADME.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
11 changes: 4 additions & 7 deletionsazure-pipelines.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletionbuild_tools/azure/install.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletionsbuild_tools/azure/linting.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
#!/bin/bash | ||
set -e | ||
# pipefail is necessary to propagate exit codes | ||
set -o pipefail | ||
flake8 --show-source . | ||
echo -e "No problem detected by flake8\n" | ||
# For docstrings and warnings of deprecated attributes to be rendered | ||
# properly, the property decorator must come before the deprecated decorator | ||
# (else they are treated as functions) | ||
# do not error when grep -B1 "@property" finds nothing | ||
set +e | ||
bad_deprecation_property_order=`git grep -A 10 "@property" -- "*.py" | awk '/@property/,/def /' | grep -B1 "@deprecated"` | ||
if [ ! -z "$bad_deprecation_property_order" ] | ||
then | ||
echo "property decorator should come before deprecated decorator" | ||
echo "found the following occurrencies:" | ||
echo $bad_deprecation_property_order | ||
exit 1 | ||
fi | ||
# Check for default doctest directives ELLIPSIS and NORMALIZE_WHITESPACE | ||
doctest_directive="$(git grep -nw -E "# doctest\: \+(ELLIPSIS|NORMALIZE_WHITESPACE)")" | ||
if [ ! -z "$doctest_directive" ] | ||
then | ||
echo "ELLIPSIS and NORMALIZE_WHITESPACE doctest directives are enabled by default, but were found in:" | ||
echo "$doctest_directive" | ||
exit 1 | ||
fi | ||
joblib_import="$(git grep -l -A 10 -E "joblib import.+delayed" -- "*.py" ":!sklearn/utils/_joblib.py" ":!sklearn/utils/fixes.py")" | ||
if [ ! -z "$joblib_import" ]; then | ||
echo "Use from sklearn.utils.fixes import delayed instead of joblib delayed. The following files contains imports to joblib.delayed:" | ||
echo "$joblib_import" | ||
exit 1 | ||
fi |
20 changes: 10 additions & 10 deletionsdoc/ensemble.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletiondoc/over_sampling.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletionsimblearn/_min_dependencies.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletionimblearn/combine/_smote_enn.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletionimblearn/combine/_smote_tomek.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
91 changes: 78 additions & 13 deletionsimblearn/ensemble/_bagging.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.