- Notifications
You must be signed in to change notification settings - Fork1.3k
[MRG] ENH add macro-averaged mean squared error#1134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Ab2nour wants to merge1 commit intoscikit-learn-contrib:masterChoose a base branch fromAb2nour:ENH/add-macro-averaged-mean-squared-error
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
[MRG] ENH add macro-averaged mean squared error#1134
Ab2nour wants to merge1 commit intoscikit-learn-contrib:masterfromAb2nour:ENH/add-macro-averaged-mean-squared-error
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Reference Issue
Closes#846
What does this implement/fix? Explain your changes.
New metric for ordinal classification:
macro_averaged_mean_squared_error
, following the same logic as the previously introducedmacro_averaged_mean_absolute_error
.Changes:
macro_averaged_mean_squared_error
__init__.py
Any other comments?
A comment in the issue suggested adding a
squared=True
parameter.As of scikit-learn 1.4 (seescikit-learn/scikit-learn#26734), this is now outdated: the new function is standalone.
Let me know if further changes are needed.