Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

API deprecate estimator_ in favor of estimators_ in CNN and OSS#1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
glemaitre merged 2 commits intoscikit-learn-contrib:masterfromglemaitre:is/908
Jul 10, 2023

Conversation

glemaitre
Copy link
Member

@glemaitreglemaitre commentedJul 9, 2023
edited
Loading

closes#908

We should make sure that the documentation mentions the one-vs.-other strategy (wrong for CNN). Then it makes sense to store all pairs of k-NN instead of the last one from the loop.
We can then deprecateestimator_ and create a newestimators_ attribute.

@glemaitreglemaitre changed the titleAPI deprecate estimator_ in favor of estimators_API deprecate estimator_ in favor of estimators_ in CNN and OSSJul 9, 2023
@glemaitreglemaitre marked this pull request as draftJuly 9, 2023 22:06
@glemaitreglemaitre marked this pull request as ready for reviewJuly 9, 2023 22:24
@glemaitreglemaitre merged commit95e21e1 intoscikit-learn-contrib:masterJul 10, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] The estimator_ in CondensedNearestNeighbour() is incorrect for multiple classes
1 participant
@glemaitre

[8]ページ先頭

©2009-2025 Movatter.jp