Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

CI Pin pytest<9 in wheels#32688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lesteve merged 3 commits intoscikit-learn:mainfromlesteve:pytest-8-wheels
Nov 11, 2025
Merged

Conversation

@lesteve
Copy link
Member

@lestevelesteve commentedNov 10, 2025
edited
Loading

Work-around for#32393 (comment).

Seepytest-dev/pytest#13895 for the pytest issue,raise unittest.SkipTest raises in pytest 9.0 released on November 8.

Could be a temporary work-around depending how fast pytest mergespytest-dev/pytest#13912 and do a new release.

@github-actions
Copy link

github-actionsbot commentedNov 10, 2025
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit:e157f88. Link to the linter CI:here

# Dot the Python version for identifying the base Docker image
PYTHON_DOCKER_IMAGE_PART=$(echo${PYTHON_VERSION:0:1}.${PYTHON_VERSION:1:2})

# TODO Remove this when Python 3.14 is released and there is a Docker image
Copy link
MemberAuthor

@lestevelesteveNov 10, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not really related to pytest<9 ... I can move it to a separate PR if someone insists 🙄.

@lestevelesteve added the Quick ReviewFor PRs that are quick to review labelNov 10, 2025
@betatim
Copy link
Member

I'd be ok to merge this to get wheels and stuff working again. We can directly open a PR that undoes the pin again so we don't forget.

@betatim
Copy link
Member

I'm surprised we don't also have to introduce the<9 limit in_min_dependencies.py

@lesteve
Copy link
MemberAuthor

OK let's merge this one to get the wheels green again!

We'll see when pytest does a 9.0.1 with the revert.

I'm surprised we don't also have to introduce the <9 limit in _min_dependencies.py

We may need to addpytest<9 inbuild_tools/update_environment_and_lock_files.py if we want to be able to update lock-files again. There is less pressure to do this, since thanks to the beauty of lock-files, most of our CI is not affected by the pytest 9.0 change.

betatim reacted with thumbs up emoji

@lestevelesteve merged commita444d5c intoscikit-learn:mainNov 11, 2025
78 checks passed
@betatim
Copy link
Member

The lockfiles is what I meant. Can you tell I don't keep the information where exactly I need to go to influence them loaded in RAM? :D

lesteve reacted with laugh emoji

@lestevelesteve deleted the pytest-8-wheels branchNovember 12, 2025 07:45
@lesteve
Copy link
MemberAuthor

The wheels build worked fine this morning 🎉https://github.com/scikit-learn/scikit-learn/actions/runs/19285781661

@lesteve
Copy link
MemberAuthor

FWIW I wouldn't do anything about the lock-files yet.

It seems like pytest is preparing a 9.0.1 releasepytest-dev/pytest#13938 which should happen soonish and has the revert of theraise unittest.SkipTest breaking change.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@betatimbetatimbetatim approved these changes

Assignees

No one assigned

Labels

Build / CIQuick ReviewFor PRs that are quick to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lesteve@betatim

[8]ページ先頭

©2009-2025 Movatter.jp