Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork26k
DOC: Add missing link to example in plot_digits_agglomeration.py#31681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
DOC: Add missing link to example in plot_digits_agglomeration.py#31681
Conversation
github-actionsbot commentedJun 30, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the PR and continuing the work from#30979,@Nachi28! I have a few comments.
- In the "Reference Issues/PRs" section of the PR description, could you please replace "
Fixes #30979" with "Towards #26927"? This helps us better track progress on the meta issue. - I also think it would be helpful to include the example link in the docstring for
FeatureAgglomeration.
Cc@StefanieSenger in advance.
I have updated both the things please verify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the update,@Nachi28. I have a few more comments.
| ..rubric::Examples | ||
| *:ref:`sphx_glr_auto_examples_cluster_plot_digits_agglomeration.py`: This | ||
| example shows how similar features are merged together using feature | ||
| agglomeration. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The example link seems a little unnecessary here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should i remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think the example link fits better underUnsupervised Dimensionality Reduction, where it's already included. Could you please remove it from here?
Uh oh!
There was an error while loading.Please reload this page.
Reference Issues/PRs
Towards#30979
Supersedes and continues work from PR#30979 by@AshleyNDoerfler
What does this implement/fix? Explain your changes.
This PR adds the missing reference link to the example
plot_digits_agglomeration.pyin the clustering user guide (clustering.rst), specifically under the Feature Agglomeration section.Additionally:
Any other comments?
Please let me know if there are any additional changes or improvements you'd like me to make.