Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bump min dependencies anticipating next major release on 2025-11-01#31656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
GaetandeCast wants to merge2 commits intoscikit-learn:main
base:main
Choose a base branch
Loading
fromGaetandeCast:bump-min-dependencies

Conversation

GaetandeCast
Copy link
Contributor

@GaetandeCastGaetandeCast commentedJun 25, 2025
edited
Loading

I will need thereturn_as=generator option of joblib 1.3 for#31279 . According to the maintenance guide, this version should be an acceptable dependency for the next major release. I updated the _min_dependencies according to the script linked in the maintainers guide. However I get the following error when trying to update the lock files:

RuntimeError: Command exited with non-zero exit code.Exit code: 1Command:conda-lock lock --mamba --kind explicit --platform linux-64 --file build_tools/azure/pylatest_conda_forge_mkl_linux-64_environment.yml --filename-template build_tools/azure/pylatest_conda_forge_mkl_linux-64_conda.lockstdout:stderr:Locking dependencies for ['linux-64']...INFO:conda_lock.conda_solver:linux-64 using specs ['python', 'numpy', 'blas * mkl', 'scipy', 'cython', 'joblib', 'threadpoolctl', 'matplotlib', 'pandas', 'pyamg', 'pytest', 'pytest-xdist', 'pillow', 'pip', 'ninja', 'meson-python', 'pytest-cov', 'coverage', 'ccache', 'pytorch', 'pytorch-cpu', 'polars', 'pyarrow', 'array-api-strict', 'scipy-doctest']Failed to parse json, Expecting value: line 1 column 1 (char 0)Could not lock the environment for platform linux-64    Command: ['/home/gaeta/miniforge3/condabin/mamba', 'create', '--prefix', '/tmp/tmp1plne90a/prefix', '--dry-run', '--json', '--override-channels', '--channel', 'conda-forge', '--channel', 'file:///tmp/tmpohnhg00y', 'python', 'numpy', 'blas * mkl', 'scipy', 'cython', 'joblib', 'threadpoolctl', 'matplotlib', 'pandas', 'pyamg', 'pytest', 'pytest-xdist', 'pillow', 'pip', 'ninja', 'meson-python', 'pytest-cov', 'coverage', 'ccache', 'pytorch', 'pytorch-cpu', 'polars', 'pyarrow', 'array-api-strict', 'scipy-doctest']

Cc:@ogrisel@glemaitre

@glemaitreglemaitre self-requested a reviewJune 25, 2025 09:23
@github-actionsGitHub Actions
Copy link

github-actionsbot commentedJun 25, 2025
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit:6901cef. Link to the linter CI:here

@glemaitre
Copy link
Member

I updated the lock files locally and push. I did not get the failures.

@virchanvirchan added the dependenciesPull requests that update a dependency file labelJun 25, 2025
@jeremiedbb
Copy link
Member

Thanks for the PR@GaetandeCast. However, I don't think that we should merge such a PR so soon after releasing 1.7. The reason is that there probably will bug-fix releases for 1.7 before 1.8 and it will kind of prevent us (or at least make it very difficult) to backport CI fixes and also add the risk that we use features that are not available in the min versions of 1.7 to fix bugs for e.g. 1.7.1.

GaetandeCast reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@glemaitreglemaitreAwaiting requested review from glemaitre

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dependenciesPull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@GaetandeCast@glemaitre@jeremiedbb@virchan

[8]ページ先頭

©2009-2025 Movatter.jp