Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

TST use global_random_seed insklearn/linear_model/tests/test_logistic.py#31362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
DeaMariaLeon wants to merge55 commits intoscikit-learn:main
base:main
Choose a base branch
Loading
fromDeaMariaLeon:logistic

Conversation

DeaMariaLeon
Copy link
Contributor

Reference Issues/PRs

Towards#22827

What does this implement/fix? Explain your changes.

Any other comments?

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedMay 13, 2025•
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit:9ab74c5. Link to the linter CI:here

@lorentzenchr
Copy link
Member

@DeaMariaLeon Please note thatLogisticRegression makes use ofrandom_state only whensolver == ‘sag’, ‘saga’ or ‘liblinear’ (to shuffle the data).

@DeaMariaLeon
Copy link
ContributorAuthor

Thank you so much@lorentzenchr!

@@ -254,13 +253,16 @@ def test_elasticnet_l1_ratio_err_helpful(LR):
# TODO(1.8): remove whole test with deprecation of multi_class
@pytest.mark.filterwarnings("ignore:.*'multi_class' was deprecated.*:FutureWarning")
@pytest.mark.parametrize("solver", ["lbfgs", "newton-cg", "sag", "saga"])
def test_multinomial_binary(solver):
def test_multinomial_binary(global_random_seed,solver):
Copy link
ContributorAuthor

@DeaMariaLeonDeaMariaLeonMay 20, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe this test doesn't need global_random_seed as it will be removed

Copy link
ContributorAuthor

@DeaMariaLeonDeaMariaLeonJun 10, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Remove test now (Guillaume's suggestion)

test_predict_2_classestest_logistic_cv_mock_scorertest_predict_iristest_sparsifytest_write_parameterstest_consistency_pathtest_liblinear_dual_random_statetest_logistic_cvtest_logistic_cv_multinomial_scoretest_multinomial_logistic_regression_string_inputstest_logistic_cv_sparsetest_logistic_regression_solverstest_logistic_regression_solvers_multiclasstest_logistic_regression_solvers_multiclass_unpenalizedtest_logistic_regression_class_weightstest_logistic_regression_multinomialtest_liblinear_decision_function_zerotest_liblinear_logregcv_sparsetest_saga_sparsetest_logreg_l1test_logreg_l1_sparse_datatest_logistic_regression_cv_refittest_logreg_predict_proba_multinomialtest_max_itertest_warm_starttest_saga_vs_liblineartest_dtype_matchtest_warm_start_converge_LRtest_elastic_net_coeffstest_elastic_net_l1_l2_equivalencetest_elastic_net_versus_sgdtest_penalty_nonetest_scores_attribute_layout_elasticnettest_multinomial_identifiability_on_iristest_sample_weight_not_modifiedtest_liblinear_not_stucktest_lr_cv_scores_differ_when_sample_weight_is_requestedtest_passing_params_without_enabling_metadata_routing
@DeaMariaLeon
Copy link
ContributorAuthor

Still need to fix these:
test_LogisticRegression_elastic_net_objective
test_LogisticRegressionCV_GridSearchCV_elastic_net but feedback for the rest would be truly appreciated.

I removed some tests after conversation with Guillaume - but I hope that's what he meant.

@DeaMariaLeonDeaMariaLeon marked this pull request as ready for reviewJuly 15, 2025 12:42
test_logistic_cv_mock_scorertest_predict_iristest_sparsifytest_write_parameterstest_consistency_pathtest_liblinear_dual_random_statetest_logistic_cvtest_logistic_cv_multinomial_scoretest_multinomial_logistic_regression_string_inputstest_logistic_cv_sparsetest_logistic_regression_solverstest_logistic_regression_solvers_multiclasstest_logistic_regression_solvers_multiclass_unpenalizedtest_logistic_regression_class_weightstest_logistic_regression_multinomialtest_liblinear_decision_function_zerotest_liblinear_logregcv_sparsetest_saga_sparsetest_logreg_l1test_logreg_l1_sparse_datatest_logistic_regression_cv_refittest_logreg_predict_proba_multinomialtest_max_itertest_warm_starttest_saga_vs_liblineartest_dtype_matchtest_warm_start_converge_LRtest_elastic_net_coeffstest_elastic_net_l1_l2_equivalencetest_elastic_net_versus_sgdtest_penalty_nonetest_scores_attribute_layout_elasticnettest_multinomial_identifiability_on_iristest_sample_weight_not_modifiedtest_liblinear_not_stucktest_lr_cv_scores_differ_when_sample_weight_is_requestedtest_passing_params_without_enabling_metadata_routingtest_LogisticRegression_elastic_net_objectivetest_LogisticRegressionCV_GridSearchCV_elastic_net
test_predict_2_classestest_logistic_cv_mock_scorertest_predict_iristest_sparsifytest_write_parameterstest_consistency_pathtest_liblinear_dual_random_statetest_logistic_cvtest_logistic_cv_multinomial_scoretest_multinomial_logistic_regression_string_inputstest_logistic_cv_sparsetest_logistic_regression_solverstest_logistic_regression_solvers_multiclasstest_logistic_regression_solvers_multiclass_unpenalizedtest_logistic_regression_class_weightstest_logistic_regression_multinomialtest_liblinear_decision_function_zerotest_liblinear_logregcv_sparsetest_saga_sparsetest_logreg_l1test_logreg_l1_sparse_datatest_logistic_regression_cv_refittest_logreg_predict_proba_multinomialtest_max_itertest_warm_starttest_saga_vs_liblineartest_dtype_matchtest_warm_start_converge_LRtest_elastic_net_coeffstest_elastic_net_l1_l2_equivalencetest_elastic_net_versus_sgdtest_penalty_nonetest_scores_attribute_layout_elasticnettest_multinomial_identifiability_on_iristest_sample_weight_not_modifiedtest_liblinear_not_stucktest_lr_cv_scores_differ_when_sample_weight_is_requestedtest_passing_params_without_enabling_metadata_routingtest_LogisticRegression_elastic_net_objectivetest_LogisticRegressionCV_GridSearchCV_elastic_net
test_predict_2_classestest_logistic_cv_mock_scorertest_predict_iristest_sparsifytest_write_parameterstest_consistency_pathtest_liblinear_dual_random_statetest_logistic_cvtest_logistic_cv_multinomial_scoretest_multinomial_logistic_regression_string_inputstest_logistic_cv_sparsetest_logistic_regression_solverstest_logistic_regression_solvers_multiclasstest_logistic_regression_solvers_multiclass_unpenalizedtest_logistic_regression_class_weightstest_logistic_regression_multinomialtest_liblinear_decision_function_zerotest_liblinear_logregcv_sparsetest_saga_sparsetest_logreg_l1test_logreg_l1_sparse_datatest_logistic_regression_cv_refittest_logreg_predict_proba_multinomialtest_max_itertest_warm_starttest_saga_vs_liblineartest_dtype_matchtest_warm_start_converge_LRtest_elastic_net_coeffstest_elastic_net_l1_l2_equivalencetest_elastic_net_versus_sgdtest_penalty_nonetest_scores_attribute_layout_elasticnettest_multinomial_identifiability_on_iristest_sample_weight_not_modifiedtest_liblinear_not_stucktest_lr_cv_scores_differ_when_sample_weight_is_requestedtest_passing_params_without_enabling_metadata_routing
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@DeaMariaLeon@lorentzenchr
[8]ページ先頭
©2009-2025 Movatter.jp