Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

MAINT Deprecate scoring='max_error' and replace it by scoring='neg_max_error'#29462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

artificialfintelligence
Copy link
Contributor

@artificialfintelligenceartificialfintelligence commentedJul 11, 2024•
edited by lesteve
Loading

Reference Issues/PRs

Fixes#29417

This deprecatesscoring='max_error and replaces it withscoring='neg_max_error'.

This is very similar to#14898 that did a similar thing forscoring='brier_score_loss' =>scoring='neg_brier_score'

What does this implement/fix? Explain your changes.

Renames themax_error scorer toneg_max_error in order to make it consistent with other scorers that havegreater_is_better = False (and consistent with the documentation as well). Deprecatesmax_error with a deprecation warning message stating that it will be removed in v1.8.

Any other comments?

Please remove the deprecation warning, deprecation test case and the two comment lines I added (which start withXXX) once the old scorer is removed.

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedJul 11, 2024•
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit:0e53cce. Link to the linter CI:here

@lestevelesteve changed the titleIssue/13887MAINT Deprecate scoring='max_error' and replace it by scoring='neg_max_error'Jul 11, 2024
@lesteve
Copy link
Member

Thanks for your PR, I edited your description and PR title to help potential reviewers!

artificialfintelligence reacted with thumbs up emojiartificialfintelligence reacted with hooray emoji

Copy link
Member

@lestevelesteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks!

artificialfintelligence reacted with hooray emoji
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Copy link
Member

@adrinjalaliadrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, and it seems consistent with the other work we've done.

artificialfintelligence reacted with hooray emoji
@adrinjalaliadrinjalali merged commit1bcddcb intoscikit-learn:mainJul 19, 2024
30 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@adrinjalaliadrinjalaliadrinjalali approved these changes

@lestevelestevelesteve approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation section 3.4.1.1 has incorrect description that would be correct if themax_loss metric were to be tweaked and renamed
3 participants
@artificialfintelligence@lesteve@adrinjalali
[8]ページ先頭
©2009-2025 Movatter.jp