NotificationsYou must be signed in to change notification settings
Fork340
Star1.2k

Quote path for regex#1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

martijnhoekstra wants to merge1 commit intoscalatest:3.1.x

base:3.1.x

Choose a base branch

frommartijnhoekstra:quothTheRegex

Open

Quote path for regex#1874

martijnhoekstra wants to merge1 commit intoscalatest:3.1.xfrommartijnhoekstra:quothTheRegex

Conversation

Copy link

martijnhoekstra commentedAug 8, 2020

Windows paths contain backslash which will be interpreted by the regex engine if left unquoted.

Targetting 3.1.x. Should it? Or should this be retargeted?

quote regex for paths

c8673db

Windows paths contain backslash which will be interpretedby the regex engine if left unquoted

Copy link

cla-botbot commentedAug 8, 2020

Hi@martijnhoekstra, we require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please accesshttps://www.artima.com/cla/choose-type to sign our Contributor License Agreement. Your effort is highly appreciated. Thank you.