Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add information about which required field was missing#1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
gregor-i wants to merge2 commits intoscalapb:master
base:master
Choose a base branch
Loading
fromgregor-i:master

Conversation

@gregor-i
Copy link

Exceptions caused by missing required fields don't mention which fields were missing, even though this information is easy to provide

@thesamet
Copy link
Contributor

Can you add unit tests? They can be based on e2e/src/main/protobuf/google/protobuf/unittest.proto and useTestRequired,TestRequiredForeign, andTestRequiredOneof, it should exercise the cases were one or more than one fields are missing.

gregor-i reacted with thumbs up emoji

@gregor-i
Copy link
Author

I've added some test cases. I didn't know how to construct incomplete messages, so my test data setup may be overcomplicated.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gregor-i@thesamet
[8]ページ先頭
©2009-2025 Movatter.jp