- Notifications
You must be signed in to change notification settings - Fork380
Fix #4143 termios Posix library does not work on Linux#4155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
@LeeTibbert I don't have a Linux env so I am not sure I can complete this. Any chance you could look into this? |
Be glad to, but it would have to be the beginning of next week, and not Tuesday, April 1. IMO, you are entirely right, any change or code not exercised or tested is, by definition, broken. I'm trying to get a large & complicated 'Arrays` JDK9 PR off the shipping dock. |
@LeeTibbert I was thinking that the smaller Linux sizes are big enough to handle 32 and 64 bit flags but wondering then what happens with struct alignment on macOS? |
Sorry this fell off the bottom of my work list. In the interest of not holding you up, I'll give the TL;DR and then TL;DRJumping to solution, this looks like a case where We, as in you and I, dealt with such an situation with, IIRC, BSD sin6_len & sin_len. The critical & discriminating pieces of information are:
If the linux systems we have at hand ignore those bytes, then we can do a DiscussionPunting, for now, the "how do we inform people about Ops methods & get them to use them?" concern.
More as it develops. |
From Neat trick to get a test to always pass, baring Exceptions. I'll have to remember that. |
| } | ||
| } | ||
| @Test def testSetRawMode(): Unit = if (!isWindows) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Understod: This rapid prototyping draft
At the risk of saying what you probably intended once
you got past step 1.
Down the line, probably want to fetch the attributes
just set, into a new poisoned (known pattern, such as repeated DEADBEEF )buffer & compare the two.
Of course any mismatch leaves open the question
of "is it set or get that is broken"? We all are
familiar with that one. At least the mismatch is
detected.
TIL: Today I learned. How to bookmark an Issue or PR so I can easily find items on my current |
Uh oh!
There was an error while loading.Please reload this page.
Testing to try and fix this issue or at least try and find a path forward.
Notes from Linux headers:
From
/usr/include/x86_64-linux-gnu/bits/termios.hFrom
/usr/include/x86_64-linux-gnu/bits/termios-struct.h