- Notifications
You must be signed in to change notification settings - Fork380
Don't wrap synchronous RPC endpoints into asynchronous ones#4116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
WojciechMazur wants to merge3 commits intoscala-native:mainChoose a base branch fromWojciechMazur:test-interface/sync-rpc-execution
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Don't wrap synchronous RPC endpoints into asynchronous ones#4116
WojciechMazur wants to merge3 commits intoscala-native:mainfromWojciechMazur:test-interface/sync-rpc-execution
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
d9b8dfd to9dd00abCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Before#1869 we have not needed explicit
concurrent.NativeExecutionContext.queueInternal.helpComplete()(previouslyruntime.loop()) invocation in theNativeRPC.loop, becouse in the old testing infrastrucure we never spawned any Futures.When porting new infra from Scala.js we've also ported some of possibly not very useful implementation details.
In Scala.js the only asynchronous RPC endpoint was used to execute the code. In Scala Nativethis endpoint was always implemented as synchronous. However, the internal implementation of the endpoint binded using
attachwas delegating the execution usingattachAsync- this required us to pass the Execution context that would be used to createonCompleteevent.In Scala.js infra and modified JUnitRuntime used the continuations to delay completion and notifing the JVM server until test execution has finished. It was never ported to Scala Native - the original port used a mostly synchronous variant to execute code , and last port in#2723 was rejected.
In this PR we makes synchronous RPC endpoints truly synchronous - we no longer create dummy Futures that serve little to no real purpose. It should not negatively affect the testing infrastructure - the JVM server would wait until current execution would finish before sending a next task to execute.
The benefit of this change is fact that now tests with more of the JVM semantics - if multithreading is enabled we would no longer use a ForkJoinPool/ExecutionContext to execute tests, but would execute them on main thread which is consistent with the JVM.