Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Don't wrap synchronous RPC endpoints into asynchronous ones#4116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
WojciechMazur wants to merge3 commits intoscala-native:main
base:main
Choose a base branch
Loading
fromWojciechMazur:test-interface/sync-rpc-execution

Conversation

@WojciechMazur
Copy link
Contributor

@WojciechMazurWojciechMazur commentedDec 15, 2024
edited
Loading

Before#1869 we have not needed explicitconcurrent.NativeExecutionContext.queueInternal.helpComplete() (previouslyruntime.loop()) invocation in theNativeRPC.loop, becouse in the old testing infrastrucure we never spawned any Futures.
When porting new infra from Scala.js we've also ported some of possibly not very useful implementation details.

In Scala.js the only asynchronous RPC endpoint was used to execute the code. In Scala Nativethis endpoint was always implemented as synchronous. However, the internal implementation of the endpoint binded usingattach was delegating the execution usingattachAsync - this required us to pass the Execution context that would be used to createonComplete event.

In Scala.js infra and modified JUnitRuntime used the continuations to delay completion and notifing the JVM server until test execution has finished. It was never ported to Scala Native - the original port used a mostly synchronous variant to execute code , and last port in#2723 was rejected.

In this PR we makes synchronous RPC endpoints truly synchronous - we no longer create dummy Futures that serve little to no real purpose. It should not negatively affect the testing infrastructure - the JVM server would wait until current execution would finish before sending a next task to execute.

The benefit of this change is fact that now tests with more of the JVM semantics - if multithreading is enabled we would no longer use a ForkJoinPool/ExecutionContext to execute tests, but would execute them on main thread which is consistent with the JVM.

@WojciechMazurWojciechMazurforce-pushed thetest-interface/sync-rpc-execution branch fromd9b8dfd to9dd00abCompareOctober 25, 2025 22:46
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@WojciechMazur

[8]ページ先頭

©2009-2025 Movatter.jp