- Notifications
You must be signed in to change notification settings - Fork384
Allow to use libunwind on Windows#3186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
WojciechMazur wants to merge6 commits intoscala-native:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Allow to use libunwind on Windows#3186
WojciechMazur wants to merge6 commits intoscala-native:mainfromWojciechMazur:feature/use-libunwind-on-windows
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Seems like libunwind is producing empty stack traces on Windows. I'm converting it into WIP until it is solved |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adapts libunwind sources to allow for compilation on Windows - which should fix some of the issues related to empty expectation stack traces which were using build Windows build-in tools. The sources have been adapted to silence warnings and fixes allowing for compilation without CMake config (used in the upstream LLVM project)
This PR should be rebased on top of#3180 and hopefully also tested on Cygwin/MSys2 when it would be available in our CI workflow