- Notifications
You must be signed in to change notification settings - Fork396
Branchless algorithm for RuntimeLong.toDouble.#5204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
817e57a
to8d55e54
Compare8d55e54
to331baa8
Compare3d8e746
to2d4e635
Comparegzm0 approved these changesJul 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice!
linker-private-library/src/main/scala/org/scalajs/linker/runtime/RuntimeLong.scala OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
It turns out the computation we did in the non-negative case alsoworks for the negative case. The proof relies on elementaryproperties of the two's complement representation.I don't know how I never saw this before. To make things worse, itseems that Kotlin and J2CL knew all along, and I never realizedwhen skimming through their implementations either.
Since conversions of signed longs to doubles is in fact no moreexpensive than the unsigned longs, we can take shorter paths forvalues that fit in the *signed* safe range.This applies to the conversions to string (including in thejavalib) and to float.It could also apply to signed division and remainder. However,benchmarks suggest that doing so makes it slower. The trouble isthat we then need a signed double-to-long conversion for theresult, and that appears to be slower than performing the 3 signadjustments.
2d4e635
tod24d1c3
Compareb9b6a6d
intoscala-js:main 3 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
It turns out the computation we did in the non-negative case also works for the negative case. The proof relies on elementary properties of the two's complement representation.
I don't know how I never saw this before. To make things worse, it seems that Kotlin and J2CL knew all along, and I never realized when skimming their implementations either.
As a second commit, we introduce code paths forsigned safe doubles, now that the conversions from signed longs to doubles is the same as the unsigned ones.