NotificationsYou must be signed in to change notification settings
Fork396
Star4.7k

Further optimize Math.rint using a floating point splitting technique.#5200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

gzm0 merged 1 commit intoscala-js:mainfromsjrd:math-rint-splitting

Jun 21, 2025

Merged

Further optimize Math.rint using a floating point splitting technique.#5200

gzm0 merged 1 commit intoscala-js:mainfromsjrd:math-rint-splitting

Jun 21, 2025

Conversation

Copy link

Member

sjrd commentedJun 20, 2025

Benchmarks show that this is markedly faster than the previous implementation. That is unsurprising, as thejs.Math.round algorithm basically had to handle x.5 valuestwice on top of the primitive hardware rounding function (once insidejs.Math.round to turn ties-to-even into ties-up; and once in our algorithm to turn ties-up back to ties-to-even).

Further optimize Math.rint using a floating point splitting technique.

e201bc0

Benchmarks show that this is markedly faster than the previousimplementation. That is unsurprising, as the `js.Math.round`algorithm basically had to handle x.5 values *twice* on top ofthe primitive hardware rounding function (once inside`js.Math.round` to turn ties-to-even into ties-up; and once inour algorithm to turn ties-up back to ties-to-even).