- Notifications
You must be signed in to change notification settings - Fork396
PoC: Support forfunction*/yield.#5082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
sjrd wants to merge2 commits intoscala-js:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedNov 26, 2024
c8a4b12 to1a985b7Compareasync/await andfunction*/yield.function*/yield.As well as the IR version to 1.20-SNAPSHOT.
Wouldfixscala-js#5079.* Only works on JS; not on Wasm.* `yield_*` should work (on JS) but is untested.* `async function*` has theoretical support in the linker, but no support in the compiler backend for now.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Wouldfix#5079.
yield_*should work (on JS) but is untested.async function*has theoretical support in the linker, but no support in the compiler backend for now.Try
helloworld2_12/run. On JS you can uncomment the code that uses the generator. Left commented out in the PR so that there's a chance the CI can get green.