- Notifications
You must be signed in to change notification settings - Fork396
WIP: Re-use previous analysis if dependency graph is unchanged#4927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Opening this to share first benchmarking results. |
no-change: org.scalajs.linker.analyzer.internal.simulateChangedInfo = false |
@sjrd I'd appreciate your opinion on this: For the initial linking step, there clearly seems to be a cost to doing this analysis, but there is also clearly a massive speed gain by doing it. I would expect that dependency preserving changes are not so rare when doing incremental development (especially when fiddling with UI and what not). So to me, this is not very clear cut :-/ |
I'm still uneasy about this. The situations where it applies are still quite rare. Even for UI tweaking, when it's not CSS-only changes, I feel like calling one method more or less (like putting an additional What would be convincing would be an in-situ noticeable difference. Try with and without the changes, on a real(-ish, possibly demo) codebase, making small changes and test whether it feels any faster. If the difference can be perceived in situations where it matters, that would make a good case for this optimization. |
Uh oh!
There was an error while loading.Please reload this page.
Fixes#4907.