NotificationsYou must be signed in to change notification settings
Fork396
Star4.7k

Commitc8c8050

committed

MarkRuntimeLong.toDouble as fully inline.

Its implementation is shorter than many of the methods we alreadyinline, like additions and multiplications. We do pay a littlecode size cost for this change.This will be particularly useful for the following commit, whichwill rely on folding to happen within `toDouble`, once inlined atcall site.

1 parent5fe402b commitc8c8050Copy full SHA for c8c8050

File tree

2 files changed

-8

lines changed

linker-private-library/src/main/scala/org/scalajs/linker/runtime
- RuntimeLong.scala
project
- Build.scala

2 files changed

-8

lines changed

`‎linker-private-library/src/main/scala/org/scalajs/linker/runtime/RuntimeLong.scala`

Lines changed: 3 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -695,10 +695,9 @@ object RuntimeLong {`
`695`	`695`	`a.lo`
`696`	`696`
`697`	`697`	`@inline`
`698`		`-deftoDouble(a:RuntimeLong):Double=`
`699`		`- toDouble(a.lo, a.hi)`
`700`		`-`
`701`		`-privatedeftoDouble(lo:Int,hi:Int):Double= {`
	`698`	`+deftoDouble(a:RuntimeLong):Double= {`
	`699`	`+vallo= a.lo`
	`700`	`+valhi= a.hi`
`702`	`701`	`if (hi<0) {`
`703`	`702`	`// We do asUint() on the hi part specifically for MinValue`
`704`	`703`	`valneg= inline_negate(lo, hi)`

`‎project/Build.scala`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -2060,17 +2060,17 @@ object Build {`
`2060`	`2060`	`))`
`2061`	`2061`	`}else {`
`2062`	`2062`	`Some(ExpectedSizes(`
`2063`		`- fastLink=425000 to426000,`
`2064`		`- fullLink=282000 to283000,`
`2065`		`- fastLinkGz=60000 to61000,`
	`2063`	`+ fastLink=426000 to427000,`
	`2064`	`+ fullLink=283000 to284000,`
	`2065`	`+ fastLinkGz=61000 to62000,`
`2066`	`2066`	`fullLinkGz=43000 to44000,`
`2067`	`2067`	`))`
`2068`	`2068`	`}`
`2069`	`2069`
`2070`	`2070`	case `default213Version`=>
`2071`	`2071`	`if (!useMinifySizes) {`
`2072`	`2072`	`Some(ExpectedSizes(`
`2073`		`- fastLink=442000 to443000,`
	`2073`	`+ fastLink=443000 to444000,`
`2074`	`2074`	`fullLink=90000 to91000,`
`2075`	`2075`	`fastLinkGz=57000 to58000,`
`2076`	`2076`	`fullLinkGz=24000 to25000,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc8c8050

File tree

2 files changed

2 files changed

`‎linker-private-library/src/main/scala/org/scalajs/linker/runtime/RuntimeLong.scala`

`‎project/Build.scala`

0 commit comments