After this change, it produces the following, which still prepends the current working directory, but properly converts path separators to/:

original: Optional[C:\foo\bar\myfile.scala]resolved: /Users/mbland/src/scala/scala3/C:/foo/bar/myfile.scala

After blowing the dust off my Windows VM, I can confirm this is platform dependent.

On Windows:

scala> java.io.File("C:\\foo\\..\\bar\\f.txt").toPath.toAbsolutePath.normalizevalres0: java.nio.file.Path=C:\bar\f.txtscala> java.io.File("C:\\foo\\..\\bar\\f.txt").toPath.toAbsolutePath.toUri.normalize.getRawPathvalres1:String=/C:/bar/f.txt

On macOS:

scala> java.io.File("C:\\foo\\..\\bar\\f.txt").toPath.toAbsolutePath.normalizevalres0: java.nio.file.Path=/Users/luc/code/scala/scala13/sandbox/C:\foo\..\bar\f.txtscala> java.io.File("C:\\foo\\..\\bar\\f.txt").toPath.toAbsolutePath.toUri.normalize.getRawPathvalres1:String=/Users/luc/code/scala/scala13/sandbox/C:%5Cfoo%5C..%5Cbar%5Cf.txt

So arguably the current implementation usingtoUri is also OK..?

So arguably the current implementation using toUri is also OK..?

Hmm, arguably, yes. So if you want, I could:

• Close this pull request outright (and maybe open a new one for Scala 2 that usestoURI and removes the Windows path assertions, to ensure parity between the implementations?)
• Pare the changes down to only add the new tests (minus the Windows path test), which may be good to have
• Keep the pull request as it is, to make the Scala 3 implementation closer to the implementation fromDon't resolve symlinks in -Wconf:src scala#11192

One other thing I noticed was that, unlike the Scala 2 implementation, thesrc filter doesn't automatically prepend/ to patterns to ensure they match an entire path component. For example, this currently fails:

@Testdef`Wconf src filter only matches entire directory path components`:Unit=valpath=Path("foobar/File.scala")valresult= wconfSrcFilterTest(      argsStr="-Wconf:src=bar/.*\\.scala:s",      warning= diagnosticWarning(util.SourceFile(newPlainFile(path),"UTF-8"))    )    assertEquals(result,Right(reporting.Action.Warning))

Note that the current tests reverse theexpected, actual ordering of theassertEquals parameters, so the assertion failure message reads backwards:

[error] Test dotty.tools.dotc.config.ScalaSettingsTests.Wconf src filter only matches entire directory path components failed:  java.lang.AssertionError: expected:<Right(Silent)> but was:<Right(Warning)>, took 0.001 sec[error]     at dotty.tools.dotc.config.ScalaSettingsTests.Wconf src filter only matches entire directory path components(ScalaSettingsTests.scala:308)

So the fourth option would be:

• Repurpose this pull request so thatsrc path prefixes only match entire directory path components.