- Notifications
You must be signed in to change notification settings - Fork1.1k
useIndexOutOfBoundsException constructor withInt#24764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
hamzaremmal wants to merge3 commits intoscala:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
+26 −23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The exact format is not part of the specification of the constructors (seehttps://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/IndexOutOfBoundsException.html#%3Cinit%3E(int))
MemberAuthor
hamzaremmal commentedDec 17, 2025
Requires Scala.js 1.20.2 when released. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The idea of using
scala.runtime.Statics.ioobewas to reduce the size of the generated bytecode.In this PR, we instead use the JDK9+ constructor of
IndexOutOfBoundsException.In the generated code,
checkcastmentioned inscala/scala#7086 (comment) is also not present making the generated code more efficient than what it looked like in Scala 2.One question remains, should we deprecate
scala.runtime.Statics.ioobe?I believe we shouldI did deprecate it.scala3/library/src/scala/runtime/Statics.java
Line 151 in7eba9a7
Closes#23971