Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Use the stdlib more instead of defining methods indotc.util#24724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
hamzaremmal wants to merge3 commits intoscala:main
base:main
Choose a base branch
Loading
fromhamzaremmal:more-cleanups

Conversation

@hamzaremmal
Copy link
Member

@hamzaremmalhamzaremmal requested a review froma team as acode ownerDecember 10, 2025 21:24
@som-snytt
Copy link
Contributor

I would expect the PR to improve library first, and this second.

@hamzaremmal
Copy link
MemberAuthor

I would expect the PR to improve library first

What do you have in mind?

@som-snytt
Copy link
Contributor

util.chaining was the first thing people wanted to inline. I guess-> is the second.#24715

@hamzaremmal
Copy link
MemberAuthor

util.chaining was the first thing people wanted to inline. I guess-> is the second.#24715

Aaah, I see what you mean. Sure. This could (will?) be done soon. Even if I do it, it will not be merged until we start working on 3.10.
This PR is just about removing duplicates in the complier codebase. It can always use the new versions later without requiring any changes.

@som-snytt
Copy link
Contributor

I would pause this change until the improvements land, since that was the reason to use compilerutil in the first place. The difference is potentially severe, since.tap could turn up in hot code and is supposed to be without cost.

@hamzaremmal
Copy link
MemberAuthor

It is here:#24725.

@bishabosha
Copy link
Member

bishabosha commentedDec 11, 2025•
edited
Loading

lets say blocked until non-bootstrapped compiler uses result of#24725?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hamzaremmal@som-snytt@bishabosha
[8]ページ先頭
©2009-2025 Movatter.jp