- Notifications
You must be signed in to change notification settings - Fork1.1k
Overcome Name comparison hurdles#24691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
som-snytt commentedDec 7, 2025
The github issue number autocomplete has gone from mostly useless to quite glitchy for me. |
som-snytt commentedDec 7, 2025
Edit: that tweak compares apples and oranges. |
0cdc6ac to8dc911bComparesom-snytt commentedDec 8, 2025
What is the behavior when the other method is from a superclass from the class path? Is its name also simple. |
8dc911b to605a439Comparesom-snytt commentedDec 8, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Is this just to defend against people using identifiers with dollars that happen to collide? Maybe this is too expensive to support, as it expensive in the happy path. Is it OK because name.toString is computed just once and is required eventually anyway? In that case, it should compare toString and not toSimpleName. (The hypothesis was that preferring comparisons with simple names would be cheaper on average, but that is untested. That is, |
605a439 to01d038cComparesom-snytt commentedDec 9, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The CB |
Uh oh!
There was an error while loading.Please reload this page.
Fixes#19274
When checking for conflicting members, track visited members by
name.toString.When checking for matching members, compare "target names" as simple names.