- Notifications
You must be signed in to change notification settings - Fork1.1k
chore: deprecate the content of thescala.runtime.stdLibPatches package#24587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
hamzaremmal wants to merge1 commit intoscala:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+9 −6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| /** Scala 3 additions and replacements to the `scala.language` object.*/ | ||
| @publicInBinary | ||
| @deprecated(message="Patches are not applied to the stdlib anymore", since="3.8.0") | ||
| private[scala]objectlanguage: |
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Consulting@sjrd for a second opinion. This should be fine since the TASTy should have symbols to the real ones that we used to patch, not the fake ones. The only reason it would break is if people refer directly to them in their source code (then, it is on them).
69c2e8f to59875ebCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
backport:nominatedIf we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I'm blocked by a bug in#24477, lets at least deprecate the objects not allow access to them anymore for 3.8.0.