- Notifications
You must be signed in to change notification settings - Fork1.1k
Encode path of class#23503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
som-snytt wants to merge2 commits intoscala:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Encode path of class#23503
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4e7430f to31c5b75Compare(Temporarily?) exclude a test from best effort neg, where the test file has a hyphen. Under JDK 23, a bootstrap error at must spin up a by-name for the There is also a long-running test in that group, also under JDK 23, but vulpix doesn't report test names (is there a verbose option?). The ``` at dotty.tools.dotc.core.MatchReducer.recur$2(TypeComparer.scala:3921) at dotty.tools.dotc.core.MatchReducer.op$proxy90$1(TypeComparer.scala:3940) at dotty.tools.dotc.core.MatchReducer.matchCases(TypeComparer.scala:3940) at dotty.tools.dotc.core.Types$MatchType.reduced$$anonfun$1(Types.scala:5239) at dotty.tools.dotc.core.Types$MatchType$$Lambda/0x00007102ef654f80.apply(Unknown Source) at dotty.tools.dotc.core.TypeComparer.inSubComparer(TypeComparer.scala:3311) at dotty.tools.dotc.core.TypeComparer.reduceMatchWith(TypeComparer.scala:3322) at dotty.tools.dotc.core.TypeComparer$.reduceMatchWith(TypeComparer.scala:3533) at dotty.tools.dotc.core.Types$MatchType.reduced(Types.scala:5239) at dotty.tools.dotc.core.Types$Type.tryNormalize(Types.scala:1593) at dotty.tools.dotc.core.Types$Type.normalized(Types.scala:1587) at dotty.tools.dotc.core.Types$MatchType.reduced$$anonfun$1(Types.scala:5239) at dotty.tools.dotc.core.Types$MatchType$$Lambda/0x00007102ef654f80.apply(Unknown Source) at dotty.tools.dotc.core.TypeComparer.inSubComparer(TypeComparer.scala:3311) at dotty.tools.dotc.core.TypeComparer.reduceMatchWith(TypeComparer.scala:3322) at dotty.tools.dotc.core.TypeComparer$.reduceMatchWith(TypeComparer.scala:3533) at dotty.tools.dotc.core.Types$MatchType.reduced(Types.scala:5239) at dotty.tools.dotc.core.Types$Type.tryNormalize(Types.scala:1593) at dotty.tools.dotc.core.Types$AppliedType.tryNormalize(Types.scala:4709) at dotty.tools.dotc.core.TypeOps$.simplify(TypeOps.scala:152) at dotty.tools.dotc.core.Types$Type.simplified(Types.scala:2101) at dotty.tools.dotc.core.MatchReducer.recur$2(TypeComparer.scala:3921) at dotty.tools.dotc.core.MatchReducer.op$proxy90$1(TypeComparer.scala:3940)``` As a branding note, it would have been great if |
ContributorAuthor
som-snytt commentedJul 11, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The JDK 23 failure is I guess it is stack. The test is an erroneous match type, so maybe it is related to the long-running test; for some reason it passes JDK 17 not 23. Exiting right away shows They say don't try to recover from SOE but we don't believe them. Maybe there is a JVM-specific dimension, besides default stack size or whatever. |
If you propagate the SOE, you are SOL and vulpix hangs. I didn't expect that. |
31c5b75 toe7db08aCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#22866
TastyFileUtil.getClassName[sic] encodes its path result so thata.bis not taken as two segments.