Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

adjust the lastFailure change to be source compatible#327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

SethTisue
Copy link
Member

@SethTisueSethTisue commentedNov 21, 2020•
edited
Loading

sequel to#234

in the community build I saw this compile error:

[playframework] [error] /home/jenkins/workspace/scala-2.13.x-jdk11-integrate-community-build/target-0.9.17/project-builds/playframework-09235f39491e975fec63cc899de593c88cef0cc0/dev-mode/routes-compiler/src/main/scala/play/routes/compiler/RoutesFileParser.scala:167:38: RoutesFileParser.this.Success.type does not take parameters[playframework] [error]         case Failure(_, _) => Success(elems.toList, in0)[playframework] [error]                                      ^

in the community build I saw this compile error:[playframework] [error] /home/jenkins/workspace/scala-2.13.x-jdk11-integrate-community-build/target-0.9.17/project-builds/playframework-09235f39491e975fec63cc899de593c88cef0cc0/dev-mode/routes-compiler/src/main/scala/play/routes/compiler/RoutesFileParser.scala:167:38: RoutesFileParser.this.Success.type does not take parameters[playframework] [error]         case Failure(_, _) => Success(elems.toList, in0)[playframework] [error]                                      ^
@SethTisue
Copy link
MemberAuthor

SethTisue commentedNov 21, 2020•
edited
Loading

I don't completely understand the code involved here, but this is my best guess at what a good fix would be

@Soya-Onishi are you still around to take a look?

@SethTisueSethTisue merged commit14fa7ee intoscala:1.2.xNov 30, 2020
@SethTisueSethTisue deleted the source-compatible-lastFailure branchMay 13, 2022 12:36
SethTisue pushed a commit to SethTisue/scala-parser-combinators that referenced this pull requestMay 13, 2022
SethTisue pushed a commit to SethTisue/scala-parser-combinators that referenced this pull requestMay 13, 2022
SethTisue pushed a commit to SethTisue/scala-parser-combinators that referenced this pull requestMay 13, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@PhilippusPhilippusAwaiting requested review from Philippus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@SethTisue
[8]ページ先頭
©2009-2025 Movatter.jp