Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add the Tasty Reader [ci: last-only]#9109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lrytz merged 282 commits intoscala:2.13.xfromscalacenter:tasty_reader
Jul 15, 2020
Merged

Conversation

@bishabosha
Copy link
Member

@bishaboshabishabosha commentedJul 10, 2020
edited
Loading

see#8865 for original guide to reviewing (which has been copied to relevant doc comments in the code)

somdoron and jhnsmth reacted with hooray emoji
bishaboshaand others added14 commitsJune 26, 2020 16:46
This commit is a squash of several commits to atomically add the feature:When indexing a scope for the first time to set up completers, addlazy annotations to symbols. At the end of the indexing, force the annotationsand if one is scala.annotation.internal.Child[T], add the symbol of T as asealed child. If we are not indexing statements, such as completing thea method and reading its parameters, force annotations as soon as each symbolis initialised, this is ok because the owner tree for the definition is alsoinitialised so forward references can be safely accessed.force sealed children after indexing scopecache RepeatedAnnotforce all annotations early, catching more errorsAlso force annotations for lookahead contexts.It would be good to see if perhaps we can share a single annotation cache pertasty file and force from one place.Force annotations for each new symbolAdditionally, when sequencing statements, only force after the whole sequence is indexed.Forceable annotations are now stored in and forced from the initial context.Made it more lazy to print parents of a class.If a LambdaPolyType is in a New tree, unwrap it.force annotations at end of createMemberSymbolonly make lazy annotation if we delay its evaluation
… class info.Before this, inherited members may not be visible at the point of forcing the annotationon a definition in the template.Also moved symbol cache to the initial context so that child contexts all pass to the samecache.
Inner classes can not be found with Mirror getRequiredClass, sowe should have another way to compare types to signatures, thisproposes to instead convert method signatures toSignature[ErasedTypeRef]
Read inner classes in signatures, force annotations after template parents
Copy link
Member

@lrytzlrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Absolutely outstanding work,@bishabosha. Thank you ❤️

sjrd, julienrf, mlachkar, bishabosha, biboudis, krzemin, sake92, somdoron, lolgab, adpi2, and japgolly reacted with hooray emojisjrd, mlachkar, bishabosha, biboudis, krzemin, sake92, lolgab, SethTisue, and japgolly reacted with rocket emoji
@lrytzlrytz merged commit5569389 intoscala:2.13.xJul 15, 2020
@SethTisueSethTisue added the release-notesworth highlighting in next release notes labelJul 23, 2020
@bishaboshabishabosha deleted the tasty_reader branchNovember 24, 2024 00:38
hamzaremmal pushed a commit to hamzaremmal/scala3 that referenced this pull requestMay 2, 2025
hamzaremmal pushed a commit to scala/scala3 that referenced this pull requestMay 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lrytzlrytzlrytz approved these changes

Assignees

No one assigned

Labels

release-notesworth highlighting in next release notes

Projects

None yet

Milestone

2.13.4

Development

Successfully merging this pull request may close these issues.

7 participants

@bishabosha@lrytz@SethTisue@scala-jenkins@julienrf@errikos@sjrd

[8]ページ先頭

©2009-2025 Movatter.jp