NotificationsYou must be signed in to change notification settings
Fork3.1k
Star14.4k

Refine MapOps in concurrent.Map, add MapFactory#10891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

lrytz wants to merge1 commit intoscala:2.13.x

base:2.13.x

Choose a base branch

fromlrytz:t13047

Open

Refine MapOps in concurrent.Map, add MapFactory#10891

lrytz wants to merge1 commit intoscala:2.13.xfromlrytz:t13047

Conversation

Copy link

Member

lrytz commentedOct 18, 2024•
edited
Loading

ThebuildFromMapOps implicit has
CC[X, Y] <: Map[X, Y] with MapOps[X, Y, CC, _]

ForCC = concurrent.Map the bound is not satisfied, we hadMapOps[_, _, mutable.Map, _].

Fixesscala/bug#13047

Need to see about bin compat...

scala-jenkins added this to the2.13.16 milestone

Oct 18, 2024

Copy link

MemberAuthor

lrytz commentedOct 18, 2024•
edited
Loading

MiMa verdict:

scala-library: Failed binary compatibility check against org.scala-lang:scala-library:2.13.15! Found 4 potential problems (filtered 1)* static method newBuilder()scala.collection.mutable.Builder in interface scala.collection.concurrent.Map does not have a correspondent in other version* static method from(scala.collection.IterableOnce)java.lang.Object in interface scala.collection.concurrent.Map does not have a correspondent in other version* in other version, classes mixing scala.collection.concurrent.Map need be recompiled to wire to the new static mixin forwarder method all super calls to method mapFactory()scala.collection.MapFactory* object scala.collection.concurrent.Map does not have a correspondent in other version

SethTisue added the library:collectionsPRs involving changes to the standard collection library label

Oct 18, 2024

Copy link

Member

SethTisue commentedOct 18, 2024

@scala/collections

SethTisue modified the milestones:2.13.16,2.13.17

Nov 6, 2024

Refine MapOps in concurrent.Map, add MapFactory

1572e96

The `buildFromMapOps` implicit has`CC[X, Y] <: Map[X, Y] with MapOps[X, Y, CC, _]`For `CC = concurrent.Map` the bound is not satisfied,we had `MapOps[_, _, mutable.Map, _]`.