Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Make lhs of#::: inLazyList.Deferrer lazier#10819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
NthPortal wants to merge2 commits intoscala:2.13.x
base:2.13.x
Choose a base branch
Loading
fromNthPortal:ll-lazier-deferrer/PR

Conversation

NthPortal
Copy link
Contributor

@NthPortalNthPortal commentedJul 27, 2024
edited
Loading

not forward compatible

  • wait until forward compatibility is disabled (2.13.16?)

He-Pin reacted with thumbs up emoji
@NthPortalNthPortal added the library:collectionsPRs involving changes to the standard collection library labelJul 27, 2024
@scala-jenkinsscala-jenkins added this to the2.13.15 milestoneJul 27, 2024
"Use the #::: method with a by-name parameter instead; see docs for more info",
since = "2.13.15"
)
def #:::[B >: A]()(prefix: LazyList[B]): LazyList[B] = prefix lazyAppendedAll l()
Copy link
ContributorAuthor

@NthPortalNthPortalJul 27, 2024
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this is a trick I learned from@‍armanbilge (deliberate fake tag, I don't want to ping) to maintain bincompat but also prevent source collision

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You can even declare it asprotected[immutable] still that it doesn't appear in the public API at all.

NthPortal and lrytz reacted with thumbs up emoji
@SethTisueSethTisue requested a review froma teamJuly 29, 2024 04:52
@NthPortal
Copy link
ContributorAuthor

I believe the failure is that they're not forward compatible? but I thought that was supposed to be disabled now?

@SethTisue
Copy link
Member

hello, nice to see you here!

I thought that was supposed to be disabled now?

Not for 2.13.15. Groundwork has been lain for disabling it, perhaps in 2.13.16.

@NthPortalNthPortal removed this from the2.13.15 milestoneAug 6, 2024
@scala-jenkinsscala-jenkins added this to the2.13.15 milestoneAug 6, 2024
@SethTisueSethTisue modified the milestones:2.13.15,2.13.16Aug 14, 2024
@SethTisue
Copy link
Member

perhaps in 2.13.16.

2.13.16 will be a modest release without bincompat changes, but it appears increasingly likely that we can start accepting this kind of PR for 2.13.17

NthPortal reacted with laugh emojiNthPortal reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sjrdsjrdsjrd left review comments

Assignees
No one assigned
Labels
library:collectionsPRs involving changes to the standard collection librarylibrary:not-forward-bincompat
Projects
None yet
Milestone
2.13.17
Development

Successfully merging this pull request may close these issues.

4 participants
@NthPortal@SethTisue@sjrd@scala-jenkins

[8]ページ先頭

©2009-2025 Movatter.jp