Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Avoid unused import warnings in REPL#10769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@som-snytt
Copy link
Contributor

@som-snyttsom-snytt commentedMay 2, 2024
edited by SethTisue
Loading

Context avoids spurious warnings for history imports, REPL's bread and butter.

When compiling user input that is only imports, turn off the warning. (It would always warn, trivially.)

Users builds may have mitigations for this which may now be removed.

Fixesscala/bug#7722

SethTisue reacted with heart emoji
@scala-jenkinsscala-jenkins added this to the2.13.15 milestoneMay 2, 2024
@sjrd
Copy link
Member

sjrd commentedMay 2, 2024

Related in Scala 3:scala/scala3#20310

@som-snytt
Copy link
ContributorAuthor

@sjrd that is what inspired this rash undertaking

@som-snyttsom-snyttforce-pushed theissue/7722-repl-unused-imports branch from7195db9 toe2ad068CompareJune 22, 2024 11:38
@som-snyttsom-snytt marked this pull request as ready for reviewJune 22, 2024 11:46
@som-snyttsom-snytt requested a review fromlrytzJune 22, 2024 11:47
@som-snyttsom-snytt added the release-notesworth highlighting in next release notes labelJun 23, 2024
Copy link
Member

@lrytzlrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

QoL!

@lrytzlrytz merged commit95b8f1a intoscala:2.13.xJun 24, 2024
@som-snyttsom-snytt deleted the issue/7722-repl-unused-imports branchJune 24, 2024 16:48
@SethTisue
Copy link
Member

nice to finally have this fixed 👍

@SethTisueSethTisue changed the titleAvoid unused import in REPLAvoid unused import warnings in REPLAug 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lrytzlrytzlrytz approved these changes

Assignees

No one assigned

Labels

release-notesworth highlighting in next release notes

Projects

None yet

Milestone

2.13.15

Development

Successfully merging this pull request may close these issues.

REPL + -Ywarn-unused-import (or, since 2.12.2-Xlint) = spurious "Unused import" warnings

5 participants

@som-snytt@sjrd@SethTisue@lrytz@scala-jenkins

[8]ページ先頭

©2009-2025 Movatter.jp