Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Warn about@elidable under -Xsource:3#10377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lrytz merged 1 commit intoscala:2.13.xfromsom-snytt:deprecate/specialized
Aug 23, 2023

Conversation

@som-snytt
Copy link
Contributor

@som-snyttsom-snytt commentedApr 19, 2023•
edited
Loading

@scala-jenkinsscala-jenkins added this to the2.13.12 milestoneApr 19, 2023
@SethTisueSethTisue added the release-notesworth highlighting in next release notes labelApr 19, 2023
@som-snyttsom-snytt marked this pull request as ready for reviewApril 19, 2023 12:58
@som-snytt
Copy link
ContributorAuthor

or maybe that is too annoying, as there is no replacement idiom.

@lrytz
Copy link
Member

Yeah, let's keep an eye onscala/scala3#17329 and close this for now.

@lrytzlrytz closed thisJun 2, 2023
@SethTisueSethTisue removed this from the2.13.12 milestoneJun 2, 2023
@SethTisue
Copy link
Member

-Xmigration exists for this kind of thing, though I suspect it's little-used.

@SethTisue
Copy link
Member

(Another possible venue is the Scala 3 migration tool.)

@som-snytt
Copy link
ContributorAuthor

At the definition, I would just deprecate, except we need deprecate under the unfortunate-Xsource:3.

Shall I reopen this forelidable? I suggested somewhere that dotty should warn that it doesn't support it, instead of silently ignoring it.

@som-snyttsom-snytt reopened thisJun 5, 2023
@scala-jenkinsscala-jenkins added this to the2.13.12 milestoneJun 5, 2023
@som-snyttsom-snyttforce-pushed thedeprecate/specialized branch frombbcac3b tof92fd37CompareJune 5, 2023 18:50
@som-snyttsom-snytt changed the titleDeprecate specialized under -Xsource:3Warn about elidable under -Xsource:3Jun 5, 2023
@som-snytt
Copy link
ContributorAuthor

The replacement idiom in the doc (for Scala 3) almost works in Scala 2, except that the conditional is not inlined.

Normally,if (false) is elided in refchecks. Currently, the optimizer doesn't touchif (1 == 1), for example, which is the result of inlining with constant value arg.

@SethTisueSethTisue modified the milestones:2.13.12,2.13.13Aug 8, 2023
@lrytz
Copy link
Member

Shall I reopen this forelidable?

You confused me there for a minute :)

@lrytzlrytz merged commit063208d intoscala:2.13.xAug 23, 2023
@som-snyttsom-snytt deleted the deprecate/specialized branchAugust 23, 2023 15:27
@SethTisueSethTisue modified the milestones:2.13.13,2.13.12Aug 23, 2023
@SethTisueSethTisue changed the titleWarn about elidable under -Xsource:3Warn about@elidable under -Xsource:3Aug 23, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lrytzlrytzlrytz approved these changes

Assignees

No one assigned

Labels

release-notesworth highlighting in next release notes

Projects

None yet

Milestone

2.13.12

Development

Successfully merging this pull request may close these issues.

4 participants

@som-snytt@lrytz@SethTisue@scala-jenkins
[8]ページ先頭
©2009-2025 Movatter.jp