Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Acceptimplicit _,implicit (x: Int) in lambdas, like Scala 3 does#10327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SethTisue merged 1 commit intoscala:2.13.xfromsom-snytt:spec/implicit-arg
Mar 18, 2023

Conversation

@som-snytt
Copy link
Contributor

@som-snyttsom-snytt commentedFeb 26, 2023
edited by SethTisue
Loading

Bring syntax in line with Scala 3 by enabling what you might already expect to work. The goal is to improve cross-building as noted atscala/scala3#14365.

Follow-up toscala/bug#3672

@scala-jenkinsscala-jenkins added this to the2.13.11 milestoneFeb 26, 2023
@som-snyttsom-snytt changed the titleUpdate spec for lambda paramsUpdate spec for lambda params [ci: last-only]Feb 26, 2023
@som-snyttsom-snytt marked this pull request as ready for reviewFebruary 27, 2023 21:55
@SethTisue
Copy link
Member

@som-snytt PR title says "update spec", but I see parser changes. is it refactoring/cleanup? or did the behavior change?

@SethTisue
Copy link
Member

I'm also unclear on the exact relationship between this and#10320? Are they conceptually part of the same change, or is this one mergeable even if the other one is delayed, or what?

@som-snyttsom-snytt changed the titleUpdate spec for lambda params [ci: last-only]Update spec and parsing of lambda params to accept Scala 3 syntax [ci: last-only]Mar 13, 2023
@som-snytt
Copy link
ContributorAuthor

@SethTisue the other PR deprecates lack of parens; this PR accepts more parens (!) which should not break anything and helps cross-compiling with dotty.

SethTisue reacted with thumbs up emoji

@SethTisueSethTisue added the release-notesworth highlighting in next release notes labelMar 14, 2023
@som-snyttsom-snytt changed the titleUpdate spec and parsing of lambda params to accept Scala 3 syntax [ci: last-only]Accept implicit _, implicit (x: Int) in lambda per Scala 3Mar 15, 2023
@som-snytt
Copy link
ContributorAuthor

Squash and rebase.

@som-snytt
Copy link
ContributorAuthor

som-snytt commentedMar 15, 2023
edited
Loading

Just when you think it couldn't get interesting, the Travis failure is not the spec build.

It says ENV is 8

17964.3 tests (junit, scalacheck, et al) | ADOPTOPENJDK=8

but

openjdk version "11.0.15.1" 2022-04-22 LTS

@lrytz
Copy link
Member

IIUC, that's the default Java version before we switch using sdkman. If you open the sdkman section (https://app.travis-ci.com/github/scala/scala/jobs/598130110 line 235) you see anotherjava -version.https://github.com/scala/scala-dev/blob/scala-dev/travis/default.yml

@som-snytt
Copy link
ContributorAuthor

@lrytz thanks I will look my time tomorrow (here it is still yesterday). As I wrote to Seth, I hope not to waste your time with Scala 2 PRs you are not paid to review.

@lrytz
Copy link
Member

Not at all, you're rather doing our our job for us :)

@SethTisueSethTisue self-assigned thisMar 16, 2023
@SethTisueSethTisue changed the titleAccept implicit _, implicit (x: Int) in lambda per Scala 3Acceptimplicit _,implicit (x: Int) in lambdas, like Scala 3 doesMar 18, 2023
@SethTisueSethTisue merged commit6bc0b69 intoscala:2.13.xMar 18, 2023
@som-snyttsom-snytt deleted the spec/implicit-arg branchMarch 18, 2023 21:34
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@SethTisueSethTisueSethTisue approved these changes

Assignees

@SethTisueSethTisue

Labels

release-notesworth highlighting in next release notes

Projects

None yet

Milestone

2.13.11

Development

Successfully merging this pull request may close these issues.

4 participants

@som-snytt@SethTisue@lrytz@scala-jenkins

[8]ページ先頭

©2009-2025 Movatter.jp