- Notifications
You must be signed in to change notification settings - Fork3.1k
Acceptimplicit _,implicit (x: Int) in lambdas, like Scala 3 does#10327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
c05c1ba to1d368bdCompareSethTisue commentedMar 13, 2023
@som-snytt PR title says "update spec", but I see parser changes. is it refactoring/cleanup? or did the behavior change? |
SethTisue commentedMar 13, 2023
I'm also unclear on the exact relationship between this and#10320? Are they conceptually part of the same change, or is this one mergeable even if the other one is delayed, or what? |
som-snytt commentedMar 13, 2023
@SethTisue the other PR deprecates lack of parens; this PR accepts more parens (!) which should not break anything and helps cross-compiling with dotty. |
som-snytt commentedMar 15, 2023
Squash and rebase. |
som-snytt commentedMar 15, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Just when you think it couldn't get interesting, the Travis failure is not the spec build. It says ENV is 8 but |
lrytz commentedMar 16, 2023
IIUC, that's the default Java version before we switch using sdkman. If you open the sdkman section (https://app.travis-ci.com/github/scala/scala/jobs/598130110 line 235) you see another |
som-snytt commentedMar 16, 2023
@lrytz thanks I will look my time tomorrow (here it is still yesterday). As I wrote to Seth, I hope not to waste your time with Scala 2 PRs you are not paid to review. |
lrytz commentedMar 16, 2023
Not at all, you're rather doing our our job for us :) |
implicit _,implicit (x: Int) in lambdas, like Scala 3 does
Uh oh!
There was an error while loading.Please reload this page.
Bring syntax in line with Scala 3 by enabling what you might already expect to work. The goal is to improve cross-building as noted atscala/scala3#14365.
Follow-up toscala/bug#3672