Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Make scalac's argument-file processing more like javac's in handling spaces and line breaks#10319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SethTisue merged 1 commit intoscala:2.13.xfromsom-snytt:tweak/argfiles
Mar 28, 2023

Conversation

@som-snytt
Copy link
Contributor

@som-snyttsom-snytt commentedFeb 19, 2023
edited by SethTisue
Loading

Fixesscala/bug#12732; the ticket has details on the behavior differences

@scala-jenkinsscala-jenkins added this to the2.13.11 milestoneFeb 19, 2023
@SethTisueSethTisue added the release-notesworth highlighting in next release notes labelFeb 19, 2023
@michelou
Copy link

michelou commentedFeb 19, 2023
edited
Loading

@som-snytt Your changes work for me, thanks. I closed PR#10316 in favor of your PR after testing your changes with several Scala 2 code examples. I also patched the 2.13.10 installation (i.e.scala-compiler.jar) on my machines until version 2.13.11 is available.

@som-snytt
Copy link
ContributorAuthor

@michelou Thanks for trying out the fix. I will probably not further tweak to be bug-compatible with Java.

To summarize, the change in 2.13.10 arrived in 2.13.9 but deemed too late in the cycle to refine, so it was reverted and deferred, but then did not receive further scrutiny; I see it got the "release notes" label, but only the-Vprint-args feature was highlighted.

I was hoping to use the same tokenizer forsys.process and arg files. That is a pipe dream. (sys.process pun.)

I'd forgotten this bug mentioned in my PR, which makes it sound like JDK has quoting bugs in both places:
https://bugs.openjdk.org/browse/JDK-8282008

The context is complicated by the reverts, but the original PRs were:
#10114
#10123

@SethTisueSethTisue added the prio:hihigh priority (used only by core team, only near release time) labelFeb 20, 2023
@som-snyttsom-snytt marked this pull request as ready for reviewFebruary 22, 2023 19:17
Copy link
Member

@SethTisueSethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks@michelou for bringing this to our attention, and thanks@som-snytt for untangling the history

@SethTisueSethTisue changed the titleRe-revert untokenized argfile, write quoted argsMake scalac's argument-file processing more like javac'sMar 13, 2023
@SethTisue
Copy link
Member

SethTisue commentedMar 13, 2023
edited
Loading

@som-snytt I improved the title and PR description a bit. not sure whether to put additional effort into it; on the one hand it's an incompatible change, so people need to know, but otoh I doubt the feature is widely used

@SethTisueSethTisue removed the prio:hihigh priority (used only by core team, only near release time) labelMar 13, 2023
@SethTisueSethTisue changed the titleMake scalac's argument-file processing more like javac'sMake scalac's argument-file processing more like javac's in handling spaces and line breaksMar 13, 2023
@SethTisueSethTisue removed their assignmentMar 13, 2023
@som-snytt
Copy link
ContributorAuthor

@SethTisue yes, I think is really a reversion. If I could go back in time and live my life over again, this is what I would do differently.

I only work on features that nobody uses, so it should be safe.

@SethTisueSethTisue self-assigned thisMar 13, 2023
@michelou
Copy link

@SethTisue Just one reminder to make sure this fix will go into release 2.13.11 :Kotlin andScala 3 do behave the same asJava in respect to the handling of argument files passed on the command line.

PS. I make use of argument files in most build scripts (bash, batch, Makefile) available from my Github repositories (e.g.kotlin-examples,dotty-examples,akka-examples, etc..) when invoking the commandsjavac,kotlinc, andscalac (v3).

@SethTisueSethTisue added the prio:hihigh priority (used only by core team, only near release time) labelMar 22, 2023
@SethTisue

This comment was marked as resolved.

@SethTisueSethTisue merged commita256d69 intoscala:2.13.xMar 28, 2023
@SethTisueSethTisue removed the prio:hihigh priority (used only by core team, only near release time) labelMar 28, 2023
@som-snyttsom-snytt deleted the tweak/argfiles branchMarch 28, 2023 16:00
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lrytzlrytzlrytz approved these changes

@SethTisueSethTisueSethTisue approved these changes

Assignees

@SethTisueSethTisue

Labels

release-notesworth highlighting in next release notes

Projects

None yet

Milestone

2.13.11

Development

Successfully merging this pull request may close these issues.

Make argfile work (more) like javac

5 participants

@som-snytt@michelou@SethTisue@lrytz@scala-jenkins

[8]ページ先頭

©2009-2025 Movatter.jp