- Notifications
You must be signed in to change notification settings - Fork3.1k
Accept and ignoreusing in method signature (to aid cross-building with Scala 3)#10075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Also accept and use a few essential option aliases(aka abbrevations), such as `-Werror` and `-Vprint`.
lrytz approved these changesJul 18, 2022
| valrequire=MultiStringSetting ("-Xplugin-require","plugin","Abort if a named plugin is not loaded.") | ||
| valpluginsDir=StringSetting ("-Xpluginsdir","path","Path to search for plugin archives.",Defaults.scalaPluginPath) | ||
| valXprint=PhasesSetting ("-Xprint","Print out program after") | ||
| .withAbbreviation ("-Vprint") |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🙏
Member
lrytz commentedJul 18, 2022
Thanks! |
using in method signatureusing in method signatureusing in method signature (to aid cross-building with Scala 3)dongjoon-hyun pushed a commit to apache/spark that referenced this pull requestSep 17, 2022
### What changes were proposed in this pull request?This PR aims to upgrade Scala to 2.12.17-https://www.scala-lang.org/news/2.12.17### Why are the changes needed?The main [change](https://github.com/scala/scala/pulls?q=is%3Apr+sort%3Aupdated-desc+milestone%3A2.12.17+is%3Amerged+label%3Arelease-notes) fo this version as follows:-scala/scala#10109-scala/scala#10075-scala/scala#10108-scala/scala#10045-scala/scala#10063-scala/scala#10042-scala/scala#10040-scala/scala#10095### Does this PR introduce _any_ user-facing change?Yes, this is a Scala version change.### How was this patch tested?Existing TestCloses#37892 from LuciferYang/SPARK-40436.Authored-by: yangjie01 <yangjie01@baidu.com>Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
LuciferYang added a commit to LuciferYang/spark that referenced this pull requestSep 20, 2022
### What changes were proposed in this pull request?This PR aims to upgrade Scala to 2.12.17-https://www.scala-lang.org/news/2.12.17### Why are the changes needed?The main [change](https://github.com/scala/scala/pulls?q=is%3Apr+sort%3Aupdated-desc+milestone%3A2.12.17+is%3Amerged+label%3Arelease-notes) fo this version as follows:-scala/scala#10109-scala/scala#10075-scala/scala#10108-scala/scala#10045-scala/scala#10063-scala/scala#10042-scala/scala#10040-scala/scala#10095### Does this PR introduce _any_ user-facing change?Yes, this is a Scala version change.### How was this patch tested?Existing TestClosesapache#37892 from LuciferYang/SPARK-40436.Authored-by: yangjie01 <yangjie01@baidu.com>Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Also accept and use a few essential option aliases (aka abbreviations), such as
-Werrorand-Vprint.#10064