- Notifications
You must be signed in to change notification settings - Fork102
Workaround to allow usage within git worktrees. fixes #110#168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
https://stackoverflow.com/a/49363242 seems as though there's a different strategy, using |
grollinger commentedDec 17, 2020
I've long been annoyed by this limitation of JGit and the inability to switch off JGit completely in sbt-git. What's missing for us to make progress on this MR? |
Very frustrating indeed. The issue to support worktrees in jgit ishttps://bugs.eclipse.org/bugs/show_bug.cgi?id=477475 |
armanbilge commentedMar 7, 2022
We're bumping into this too over intypelevel/sbt-typelevel. I'd prefer to see an upstream fix rather than hack it in our plugin, but I understand if that's also the case here :) Is there something that would help get this PR merged, or is it effectively a won't -fix? Thanks! |
SethTisue commentedMar 7, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I don't think anyone really "owns" the code in this repo anymore. I'm happy to merge the PR if people want it (using my sbt/* admin rights, which I can't afford to spendtoo much time exercising intoo many different repos...) ...but I'd like to have some indication that the actual changes have been reviewed to the best of our collective abilities. |
SethTisue commentedMar 7, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Does anyone have any response to@blast-hardcheese's question? Are y'all confident this PR is needed? |
armanbilge commentedMar 7, 2022
Thank you so much for the response! Pinging@djspiewak as he's the one that flagged up these issues to me. |
@SethTisue This is definitely still needed. JGit breaks a lot more than just worktrees, though that's certainly the most visible scenario. I've also seen situations where |
Wholeheartedly agree. Bikeshedding the solution is not as important as having a solution, I'm fully onboard with whatever works. |
armanbilge commentedMar 10, 2022
@SethTisue would you feel okay to move ahead with this? Or should we give a chance for someone else to chime in. Thanks! :) |
I'll merge on Monday or Tuesday if there's no further feedback by then. |
As for releasing this, seeking volunteer assistance on#215 |
Uh oh!
There was an error while loading.Please reload this page.
Adds a
useConsoleForROGit
setting anduseReadableConsoleGit
util, so that the plugin can be used with worktreesUsage: