Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Workaround to allow usage within git worktrees. fixes #110#168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SethTisue merged 1 commit intosbt:mainfromhughsimpson:support-git-worktrees
Mar 15, 2022

Conversation

hughsimpson
Copy link
Contributor

@hughsimpsonhughsimpson commentedJun 11, 2019
edited
Loading

Adds auseConsoleForROGit setting anduseReadableConsoleGit util, so that the plugin can be used with worktrees
Usage:

import com.typesafe.sbt.SbtGit._useReadableConsoleGit

@hughsimpsonhughsimpson changed the title#110#110 Workaround to allow usage within git worktreesJun 11, 2019
@hughsimpsonhughsimpson changed the title#110 Workaround to allow usage within git worktreesWorkaround to allow usage within git worktrees. fixes #110Jun 12, 2019
@blast-hardcheese
Copy link
Contributor

https://stackoverflow.com/a/49363242 seems as though there's a different strategy, usingGit.open instead, no need for a workaround

@grollinger
Copy link

I've long been annoyed by this limitation of JGit and the inability to switch off JGit completely in sbt-git.

What's missing for us to make progress on this MR?
I'd be willing to help if I can.

blast-hardcheese, jason-yeo-paidy, and raboof reacted with heart emoji

@raboof
Copy link
Collaborator

Very frustrating indeed. The issue to support worktrees in jgit ishttps://bugs.eclipse.org/bugs/show_bug.cgi?id=477475

@armanbilge
Copy link

We're bumping into this too over intypelevel/sbt-typelevel. I'd prefer to see an upstream fix rather than hack it in our plugin, but I understand if that's also the case here :)

Is there something that would help get this PR merged, or is it effectively a won't -fix? Thanks!

@SethTisue
Copy link
Member

SethTisue commentedMar 7, 2022
edited
Loading

I don't think anyone really "owns" the code in this repo anymore.

I'm happy to merge the PR if people want it (using my sbt/* admin rights, which I can't afford to spendtoo much time exercising intoo many different repos...)

...but I'd like to have some indication that the actual changes have been reviewed to the best of our collective abilities.

@SethTisue
Copy link
Member

SethTisue commentedMar 7, 2022
edited
Loading

Does anyone have any response to@blast-hardcheese's question? Are y'all confident this PR is needed?

@armanbilge
Copy link

Thank you so much for the response! Pinging@djspiewak as he's the one that flagged up these issues to me.

@djspiewak
Copy link
Contributor

@SethTisue This is definitely still needed.

JGit breaks a lot more than just worktrees, though that's certainly the most visible scenario. I've also seen situations where.gitignores that use more complex semantics aren't properly respected, and also nearly everything involving submodules doesn't work quite how it should. This PR would literally fix most of what's broken about sbt-git right now, to the point where I would almost advocate going further and defaulting the setting totrue.

blast-hardcheese reacted with heart emoji

@blast-hardcheese
Copy link
Contributor

Wholeheartedly agree. Bikeshedding the solution is not as important as having a solution, I'm fully onboard with whatever works.

djspiewak reacted with thumbs up emoji

@armanbilge
Copy link

@SethTisue would you feel okay to move ahead with this? Or should we give a chance for someone else to chime in. Thanks! :)

@SethTisue
Copy link
Member

I'll merge on Monday or Tuesday if there's no further feedback by then.

armanbilge reacted with heart emoji

@SethTisueSethTisue merged commitae227f6 intosbt:mainMar 15, 2022
@SethTisue
Copy link
Member

As for releasing this, seeking volunteer assistance on#215

@hughsimpsonhughsimpson deleted the support-git-worktrees branchOctober 27, 2022 14:11
@mkurzmkurz mentioned this pull requestOct 7, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7 participants
@hughsimpson@blast-hardcheese@grollinger@raboof@armanbilge@SethTisue@djspiewak

[8]ページ先頭

©2009-2025 Movatter.jp